1417933 - Titlebar is shown despite settings to draw in the titlebar

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: titlebars.png

I've set "widget.allow-client-side-decoration" to true.

The titlebar is still shown and the window controls are shown twice.

Comment 1

[N. W.]

(In reply to Marco Castelluccio [:marco] from comment #0)
> Created attachment 8929012 [details]
> titlebars.png
> 
> I've set "widget.allow-client-side-decoration" to true.
> 
> The titlebar is still shown and the window controls are shown twice.

Maybe you forgot to set "browser.tabs.drawInTitlebar" to "true" ?

Comment 2

[Marco Castelluccio [:marco]]

(In reply to N. W. from comment #1)
> Maybe you forgot to set "browser.tabs.drawInTitlebar" to "true" ?

It is true by default.

Comment 3

[Noah Davis]

Attachment: Firefox 59 decorations bug on KDE Plasma 5.11.3

I have the same bug on openSUSE Tumbleweed (snapshot 20171115) in KDE Plasma 5.11.3
I too have "widget.allow-client-side-decoration" and "browser.tabs.drawInTitlebar" set to "true".

Comment 4

[gabrielhuwe]

Attachment: Firefox 59 decorations bug, XFCE 4.12

Same bug here in XFCE 4.12 (Arch Linux), both "widget.allow-client-side-decoration" and "browser.tabs.drawInTitlebar" are set to true.

Comment 5

[helios.solaris]

Same issue. Firefox 59 nightly on debian testing, xfce 4.12.
widget.allow-client-side-decoration" and "browser.tabs.drawInTitlebar" are set to true.

Comment 6

[aleksandar]

I've described the same issue here: https://bugzilla.mozilla.org/show_bug.cgi?id=1283299#c112

Copy of my comment:

> Experiencing a weird "double-icons" issue, most notably seen in the middle photo of the already uploaded attachment in this thread: https://bug1283299.bmoattachments.org/attachment.cgi?id=8901247
> 
> Loosely explained, it seems to work as expected, however, the titlebar doesn't get removed. As a result, I have two sets of windows controls.
> 
> You can see the result here: https://i.imgur.com/JpLMpS0.png
> 
> Running Ubuntu 17.10 and Nightly from the PPA (so the version 59.0a1 (2017-11-16)). I can confirm that I'm experiencing the same issue with both Wayland and X11 sessions. Both "widget.allow-client-side-decorations" and "browser.tabs.drawInTitlebar" have been set to true.
> 
> In the unmaximized fields, I see a top line between the old titlebar and the new titlebar+tabs (https://i.imgur.com/46kRc7A.png). When the window is maximized, the line disappears.
> 
> In the Customize window, both "Title Bar" and "Drag Space" are unchecked. Using the default theme (slightly modified using userChrome.css, but I've recreated this using a temporary profile as well) and density set to Touch.
> 
> Not sure what else I could do to help you out with replicating this issue, but I'll be glad to provide further info if necessary.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

XFCE and KDE should be supported here, maybe Gtk+ version does the difference. Which distro do you guys run? I see Ubuntu 17.10, anything else?

Comment 8

[helios.solaris]

(In reply to Martin Stránský [:stransky] from comment #7)
> XFCE and KDE should be supported here, maybe Gtk+ version does the
> difference. Which distro do you guys run? I see Ubuntu 17.10, anything else?

Debian testing & XFCE 4.12, libgtk 3.22.

Comment 9

[Noah Davis]

(In reply to Martin Stránský [:stransky] from comment #7)
> XFCE and KDE should be supported here, maybe Gtk+ version does the
> difference. Which distro do you guys run? I see Ubuntu 17.10, anything else?

In my previous comment, I mentioned I use openSUSE Tumbleweed
I'm using GTK 3.22

Comment 10

[gabrielhuwe]

(In reply to Martin Stránský [:stransky] from comment #7)
> XFCE and KDE should be supported here, maybe Gtk+ version does the
> difference. Which distro do you guys run? I see Ubuntu 17.10, anything else?

Arch Linux, GTK3 3.22, GTK2 2.24

Comment 11

[Marco Castelluccio [:marco]]

Ubuntu 17.10 (switching back to Fedora soon!), GTK 3.22.25.

Comment 12

[moriel5]

I am having the same issues, but only when Firefox is running as a user process, when running as root all is fine.
Vanilla Firefox 59 (2017-11-18 (I had just updated, with no visible changes pertaining this issue)) (I had manually pushed the files to /usr/, Solus Unstable, libgtk-3 3.22.26, running Budgie 10.4.

As to why I even run Firefox as root, I only do it to update Firefox, as on Windows (I don't have the patience to manually update Firefox every day).

Comment 13

[gabrielhuwe]

Running it as root here doesn't work, the titlebar is still there.

Comment 14

[helios.solaris]

(In reply to gabrielhuwe from comment #13)
> Running it as root here doesn't work, the titlebar is still there.

For me (debian testing) running as root doesn't help either.

Comment 15

[Alexander Browne]

I'm seeing the same thing in Ubuntu MATE 17.10 with both the default window manager Marco and with Compiz.

Comment 16

[Kestrel]

Running as root gets rid of the titlebar for me on Ubuntu 17.10 (Xorg).

Comment 17

[N. W.]

Attachment: Nightly_2017-11-18_KDE_neon.png

Comment 18

[N. W.]

(In reply to Martin Stránský [:stransky] from comment #7)
> XFCE and KDE should be supported here, maybe Gtk+ version does the
> difference. Which distro do you guys run? I see Ubuntu 17.10, anything else?

Running KDE neon as the distro here, which basically is the official KDE distro and is always up-to-date with the latest KDE software: https://neon.kde.org/

KDE neon is currently based on Ubuntu 16.04, which uses GTK+ 3.18. This is what it looks like here:

https://bugzilla.mozilla.org/attachment.cgi?id=8929825

As you can see, the title bar is still visible, so the window controls are duplicated. Furthermore, as you can see from the screenshot, there is a a bit of additional space between the tab bar and the title bar, which looks odd.

Additionally, the window controls in the tab bar look odd, which probably is: https://bugzilla.mozilla.org/show_bug.cgi?id=1408335

Comment 19

[aleksandar]

I can confirm that running Nightly as root on Ubuntu 17.10 (in an X11 session) gets rid of the title bar.

Comment 20

[Noah Davis]

Running as root did not remove the title bar for me on openSUSE Tumbleweed.

Comment 21

[naikel]

Running as root doesn't remove the title bar in Debian testing, XFCE 4.12, GTK 3.22.

Comment 22

[isaac.newt.list]

Running as root removes titlebar for me - Solus Budgie (10.4), GTK 3.22.  Normal user retains titlebar though.

Comment 23

[Martin Stránský [:stransky] (ni? me)]

Yes, I can see that on KDE on some other WM. Looks like only gnome-shell and Cinamon support to remove titlebar but simultaneously provide resize handlers.

We'd need to disable all decorations on the incompatible WM and provide resize handlers as Chrome does on Linux.

Comment 24

[Martin Stránský [:stransky] (ni? me)]

The solution would be based on https://reviewboard.mozilla.org/r/62490/diff/1#index_header

Comment 25

[Martin Stránský [:stransky] (ni? me)]

Partial fix (without the resizers implementation) will land at Bug 1418829.

Comment 26

[Marco Castelluccio [:marco]]

(In reply to Martin Stránský [:stransky] from comment #23)
> Yes, I can see that on KDE on some other WM. Looks like only gnome-shell and
> Cinamon support to remove titlebar but simultaneously provide resize
> handlers.
> 
> We'd need to disable all decorations on the incompatible WM and provide
> resize handlers as Chrome does on Linux.

I'm using gnome-shell on Ubuntu.

Comment 27

[Martin Stránský [:stransky] (ni? me)]

Please note that "widget.allow-client-side-decoration" is going to be removed at Bug 1418829 and only "browser.tabs.drawInTitlebar" does the titlebar rendering control.

Comment 28

[christian.ohrfandl]

Hi,
despite enabling CSD (customize / Title Bar [x]), the CSD titlebar is not shown on Pantheon (elemenaryOS) aswell.

echo $XDG_CURRENT_DESKTOP
Pantheon

Comment 29

[Martin Stránský [:stransky] (ni? me)]

(In reply to christian.ohrfandl from comment #28)
> Hi,
> despite enabling CSD (customize / Title Bar [x]), the CSD titlebar is not
> shown on Pantheon (elemenaryOS) aswell.
> 
> echo $XDG_CURRENT_DESKTOP
> Pantheon

We may need to be more flexible here, I'm considering a kind of env variable to override the CSD detection.

Comment 30

[Martin Stránský [:stransky] (ni? me)]

Pantheon (elemenaryOS) is Bug 1420818 now.

Comment 31

[rnd]

Same problem here. FF nightly build (59, up to date) Ubuntu 17.10 running gnome-shell and have tried both xorg and wayland.

Comment 32

[rnd]

Update, fix found here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1283299

by running:
env MOZ_GTK_TITLEBAR_DECORATION=client ./firefox

Comment 33

[Terrell Kelley]

Changing that variable is not working for me.

Previously the titlebar setting did work. It is no longer working, and no overrides are helping, but stopped working with yesterday's Nightly update.

Comment 34

[Martin Stránský [:stransky] (ni? me)]

Please note that due to regression Bug 1423810 the titlebar rendering was temporary disabled on systems other than gnome-shell/Cinnamon. It's tracked as Bug 1424974.

Comment 35

[N. W.]

Is there any update on this?

When using the latest Nightly on KDE Plasma and disabling the "Titlebar" checkbox under "Customize", the titlebar is still being drawn by KWin (compositor/window manager) and there are not additional window minimize/maximize/close buttons being drawn inside Firefox.

Comment 36

[Terrell Kelley]

Agreed. I have asked in Bug 1423810 why titlebar rendering has not been turned back on now that Bug 1424974 is listed as fixed.

Comment 37

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1417933 - enable CSD titlebar rendering mode as Bug 1424974 regression is fixed,

Review commit: https://reviewboard.mozilla.org/r/211304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211304/

Comment 38

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1417933 - enable CSD titlebar rendering mode on Unity desktop,

Review commit: https://reviewboard.mozilla.org/r/211306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211306/

Comment 39

[N. W.]

(In reply to N. W. from comment #35)
> Is there any update on this?
> 
> When using the latest Nightly on KDE Plasma and disabling the "Titlebar"
> checkbox under "Customize", the titlebar is still being drawn by KWin
> (compositor/window manager) and there are not additional window
> minimize/maximize/close buttons being drawn inside Firefox.

Still not working with Nightly 59.0a1 (2013-01-13) (64-bit).

Comment 40

[helios.solaris]

Titlebar also persists for me in 59.0a1 2018-01-13 64-Bit on Debian Unstable / XFCE. Also no minimize/maximize/close buttons inside firefox.
widget.allow-client-side-decoration = true
browser.tabs.drawInTitlebar = true
widget.allow-client-side-decoration = true

Comment 41

[Jan Horak [:jhorak]]

Comment on attachment 8941011 [details]
Bug 1417933 - enable CSD titlebar rendering mode on Unity desktop,

https://reviewboard.mozilla.org/r/211306/#review218572

Comment 42

[Jan Horak [:jhorak]]

Comment on attachment 8941010 [details]
Bug 1417933 - enable CSD titlebar rendering mode as Bug 1424974 regression is fixed,

https://reviewboard.mozilla.org/r/211304/#review218786

Comment 43

[Jan Horak [:jhorak]]

Comment on attachment 8941011 [details]
Bug 1417933 - enable CSD titlebar rendering mode on Unity desktop,

https://reviewboard.mozilla.org/r/211306/#review218788

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fbda7310828
enable CSD titlebar rendering mode as Bug 1424974 regression is fixed, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/7d2121c8e0dd
enable CSD titlebar rendering mode on Unity desktop, r=jhorak

Comment 45

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4fbda7310828
https://hg.mozilla.org/mozilla-central/rev/7d2121c8e0dd

Comment 46

[helios.solaris]

Finally the titlebar is gone, a big thanks to the people who are working on it.
However it still doesn't look optimal, there is a bit of room above the tabs:
https://i.imgur.com/mR0vDtE.png
(Debian unstable, XFCE)

Comment 47

[rnd]

YES!!  A big thanks!
FYI, mine appears fine (no extra space above tabs).
Ubuntu 17.10, gnome-shell, Wayland.

Comment 48

[Martin Stránský [:stransky] (ni? me)]

(In reply to helios.solaris from comment #46)
> Finally the titlebar is gone, a big thanks to the people who are working on
> it.
> However it still doesn't look optimal, there is a bit of room above the tabs:
> https://i.imgur.com/mR0vDtE.png
> (Debian unstable, XFCE)

That's Bug 1419442.

Comment 49

[Terrell Kelley]

This is currently NOT fixed for me, when it worked just fine before it was disabled to fix that other bug. I am on Ubuntu 14.04 LTS, which is still supported for another year. Was this perhaps only fixed for GTK 3.20+ instead of 3.10+, as before?

Comment 50

[Martin Stránský [:stransky] (ni? me)]

(In reply to Terrell Kelley from comment #49)
> This is currently NOT fixed for me, when it worked just fine before it was
> disabled to fix that other bug. I am on Ubuntu 14.04 LTS, which is still
> supported for another year. Was this perhaps only fixed for GTK 3.20+
> instead of 3.10+, as before?

Please file another bug for that.

Comment 51

[Terrell Kelley]

(In reply to Martin Stránský [:stransky] from comment #50)

> Please file another bug for that.

Filed as Bug 1431429