1420819 - Run MediaCache::Flush() off the main thread

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://searchfox.org/mozilla-central/rev/8839daefd69087d7ac2655b72790d3a25b6a815c/dom/media/MediaCache.cpp#680-693

FreeBlock(), Truncate(), mBlockCache->Flush() are all safe to run off the main thread with the cache monitor held.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1420819 - run MediaCache::Flush() off the main thread.

Review commit: https://reviewboard.mozilla.org/r/203746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203746/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8932683 [details]
Bug 1420819 - run MediaCache::Flush() off the main thread.

https://reviewboard.mozilla.org/r/203746/#review209218

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8932683 [details]
Bug 1420819 - run MediaCache::Flush() off the main thread.

https://reviewboard.mozilla.org/r/203746/#review209242

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8316864557a2
run MediaCache::Flush() off the main thread. r=bechen,gerald

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8316864557a2