Closed Bug 1420884 Opened 2 years ago Closed 2 years ago

Long wrapping labels cause changing corresponding button height

Categories

(Firefox :: Preferences, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- verified

People

(Reporter: MikkCZ, Assigned: evanxd)

References

Details

(Keywords: nightly-community)

Attachments

(2 files)

Attached image screenshot
STR:
1. With Nightly, open about:preferences > Privacy & Security.
2. Open DevTools or any sidebar or just resize the window to cause long labels to wrap to second line.
3. When the place for content is too narrow and lines start to wrap, the corresponding buttons on the same lines are stretched in their height.

Personally I have noticed this in Czech (cs) Nightly with "Autofill credit cards" and "Learn more" on the same line.

Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171126220311
Ricky, can you take this? We should be using -moz-box-align: start to fix this I believe.
Flags: needinfo?(rchien)
Priority: -- → P4
I've tried `-moz-box-align: start` approach in devtools and it works as expected. 
 
Evan, since my hands are full now, do you have time to take this?
Flags: needinfo?(rchien) → needinfo?(evan)
Sure, I could help this.
Assignee: nobody → evan
Status: NEW → ASSIGNED
Flags: needinfo?(evan)
Attachment #8935720 - Flags: review?(scwwu)
Hi Scott,

Could you help review the patch?

Thank you very much.
Comment on attachment 8935720 [details]
Bug 1420884 - Make savedAddressesBtnWrapper and savedCreditCardsBtnWrapper align start to keep the buttons as same size when the sibling description elements' height is changed by longer l10n strings.

https://reviewboard.mozilla.org/r/206618/#review214370

Looks great. Thanks for fixing this! Passing this to Ray as I don't have L3 status.
Attachment #8935720 - Flags: review?(scwwu)
Attachment #8935720 - Flags: review?(ralin)
Comment on attachment 8935720 [details]
Bug 1420884 - Make savedAddressesBtnWrapper and savedCreditCardsBtnWrapper align start to keep the buttons as same size when the sibling description elements' height is changed by longer l10n strings.

https://reviewboard.mozilla.org/r/206618/#review214394
Attachment #8935720 - Flags: review?(ralin) → review+
Thanks for reviewing, Scott and Ray.

And the try looks good. Let's land the patch.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71166a8df9fc
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15d8b89eb665
Make savedAddressesBtnWrapper and savedCreditCardsBtnWrapper align start to keep the buttons as same size when the sibling description elements' height is changed by longer l10n strings. r=ralin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/15d8b89eb665
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
I can confirm it's fixed in Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171220220602. Good job!
You need to log in before you can comment on or make changes to this bug.