1412247 - [Form Autofill] "Saved credit cards…" buttons is too tall if associated checkbox wraps on two lines

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Francesco Lodolo [:flod]]

Attachment: screenshot.png

See attached screenshot: "Autofill credit cards" is much longer in Italian, and wraps on two lines. The button height seems to be affected by that.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Capture d%u2019écran 2017-10-30 à 13.51.07.png

Got also an issue from French: the learn more link should be inline with the label.

Comment 2

[Luke Chang [:lchang] (inactive)]

Form Autofill is only enabled on Fx58 en-US build so set firefox58:unaffected.

Comment 3

[Scott Wu [:scottwu]]

Attachment: Bug 1412247 - Ensure checkbox label and "Learn more" link stay on the same line.

Review commit: https://reviewboard.mozilla.org/r/211966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211966/

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8941746 [details]
Bug 1412247 - Ensure checkbox label and "Learn more" link stay on the same line.

https://reviewboard.mozilla.org/r/211966/#review218072

::: browser/extensions/formautofill/FormAutofillUtils.jsm:169
(Diff revision 1)
>  };
>  
>  this.FormAutofillUtils = {
>    get AUTOFILL_FIELDS_THRESHOLD() { return 3; },
>    get isAutofillEnabled() { return this.isAutofillAddressesEnabled || this.isAutofillCreditCardsEnabled; },
> -  get isAutofillCreditCardsEnabled() { return this.isAutofillCreditCardsAvailable && this._isAutofillCreditCardsEnabled; },
> +  get isAutofillCreditCardsEnabled() { return this.isAutofillCreditCardsAvailable && this.isAutofillCreditCardsEnabled; },

You introduced a recursive call here. Can't we use the original `isAutofillCreditCardsEnabled` directly?

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8941746 [details]
Bug 1412247 - Ensure checkbox label and "Learn more" link stay on the same line.

https://reviewboard.mozilla.org/r/211966/#review218072

> You introduced a recursive call here. Can't we use the original `isAutofillCreditCardsEnabled` directly?

Oops that's embarrassing.. I originally thought I added the underscore by mistake and wanted to correct it. I've changed it back.

Comment 6

[Scott Wu [:scottwu]]

Comment on attachment 8941746 [details]
Bug 1412247 - Ensure checkbox label and "Learn more" link stay on the same line.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211966/diff/1-2/

Comment 7

[Scott Wu [:scottwu]]

Comment on attachment 8941746 [details]
Bug 1412247 - Ensure checkbox label and "Learn more" link stay on the same line.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211966/diff/2-3/

Comment 8

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8941746 [details]
Bug 1412247 - Ensure checkbox label and "Learn more" link stay on the same line.

https://reviewboard.mozilla.org/r/211966/#review218460

Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48d3e471b9aa
Ensure checkbox label and "Learn more" link stay on the same line. r=lchang

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/48d3e471b9aa

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I managed to reproduced this issue using Firefox 58.0a1 Italian-build (2017.10.27) on Windows 8.1 x64.
I verified on 2018.01.15 Fx 59.0a1 (build ID=20180115100056) Italian-build and I observed that the checkbox lable and the "Learn more" link is not in the same line, attached 2018.01.15-good.jpg. 
Then I verified on 2018.01.16 build (ID=20180116100114)and attached for this 2018.01.16-bad.jpg, the same happend on Fx 60.0a1 it-build from 2018.02.02.

Comment 12

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: 2018.01.15-good.jpg

Comment 13

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: 2018.01.16-bad.jpg

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

This bug should remain resolved-fixed as we are not backing this patch out and we are not landing any more patches in this bug.

Comment 15

[Rares Doghi, Desktop QA]

I can Confirm this issue as Fixed in Firefox 66.0a1 (2018-12-20).