1420978 - Bug 1338798 followup, test for treeBox.view in ensureRowsIsVisible()

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, enhancement)

Description

[alta88]

+++ This bug was initially created as a clone of Bug #1338798 +++

(In reply to :aceman from comment #8)
> Created attachment 8839820 [details] [diff] [review]
> alternate solution for this.view.dbView
> 
> I have looked at the patches and what the tests do. For the this.view.dbView
> I propose an alternate solution here.
> 
> Using treeBox.view returns the correct number of rows in this particular
> test (and does not visibly regress others,
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=7336e0359c5dc4480516ff0ee2ca4ef016cfd8b5). I don't know why
> treeBox.view is not null and this.view.dbView is in this case. But I think
> when the function ensureRowsIsVisible and also ensureRowRangeIsVisible
> calculate everything based on attributes of treeBox, why should we take
> rowCount from a different object (this.view.dbView).

So while treeBox is better to test for, swapping non testing for .dbView for non testing for treeBox.view isn't really a whole lot better..

Anyway, this broke MoreLayouts and I'd rather not monkey patch it.

Comment 1

[alta88]

Attachment: treeBox.patch

Comment 2

[:aceman]

Comment on attachment 8932156 [details] [diff] [review]
treeBox.patch

Review of attachment 8932156 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, even more robustness shouldn't hurt, when we access the treeBox.view later on.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dfb07694e8cf
Bug 1338798 follow-up: test for treeBox.view in ensureRowsIsVisible(). r=aceman