14211 - Mac UI: Bookmarks Prop. dialog non-modal, yet has OK/Cancel

Status: RESOLVED EXPIRED

(SeaMonkey :: UI Design, defect)

Description

[Mike Pinkerton (not reading bugmail)]

The bookmarks properties dialog is a severe violation of the mac ui guidelines.
it has a close box and is non-modal (which means it isn't a dialog) yet it has
ok/cancel buttons. Not allowed.

Comment 1

[Steve Lamm]

I cannot find the properties dialog in the bookmarks spec. The spec describes on
the of intermediate tasks as, "View multiple item properties at a glance" right
after marquee selection. I am guessing that means the properties dialog should
be non-modal. What buttons should the dialog have then? (The non-modal
properties dialog in IE has Ok, Cancel, Apply.) Does this bug belong under some
general dialog bug?

Reassigning to german for for some direction. I can take it back after that.

Comment 2

[Steve Lamm]

I also wanted to add that the current properties dialog is pretty scary. It has
some stuff tacked on about checking/updating bookmarks. Is that something we
want for the final product? Is there a better way we can integrate that feature?

Comment 3

[Steve Lamm]

I also wanted to add that the current properties dialog is pretty scary. It has
some stuff tacked on about checking/updating bookmarks. Is that something we
want for the final product? Is there a better way we can integrate that feature?

Comment 4

[german]

I haven't spec'd that part yet, but here's the thought:
it should be either a modal dialog that gets dismissed after pressing OK cancel
or it should be a floating properties 'palette' that stays on top and is 'owned'
by the 'manage bookmarks' window, and that updates dynamically based on
selection of the bookamrks window. An alternative would be to integrate the
properties of the selection directly into the 'manage bookmarks' dialog, with
complete set of editing capabilities. What do you guys think?
Wrt to the update features I am not sure we are even planning on shipping this
for 5.0 (cc'ing John), but if we do I think it is reasonable to have that in
this properties dialog.

Comment 5

[german]

Don could you let me know which version mentioned above is feasible (if at all)
for a beta 1 cleanup. Feel free to re-assign back to me if you need this more
spec'd out.

Comment 6

[don]

Move to M16 ...

Comment 7

[Viswanath Ramachandran]

Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy

Comment 8

[Adam]

The Properties dialog, accessible via the Manage Bookmarks window, is now a true
dialog (no close/resize/windowshade widgets). I think that this can be marked FIXED.

Comment 9

[Paul Chen]

nav triage team:

Still isn't quite right, but there certainly is no close box anymore. Marking
fixed.

Comment 10

[Claudius Gayle]

sorry, this does even meet the lowest hurdle for 'fixed'. There are OK/Cancel buttons but
there is still a close box and windowshade widget, the only thing this modeless window doesn't
do is resize.

Comment 11

[Viswanath Ramachandran]

sending to ben, bookmarks stuff. 

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Yep. One day we'll have a cleverer set of XP dialog XBL bindings that will 
figure out the right thing to do. Windows should use a dialog, Mac a window. 

Comment 13

[Frankie]

For clarity, here is the relevant URL and quote.

http://developer.apple.com/techpubs/macosx/Essentials/AquaHIGuidelines/AHIGDialogs/chapter_6_section_2.html

"Mac OS X applications can use these types of dialogs:
    * Modeless: Enables users to change settings in a dialog while still
interacting with document windows; the “find and replace” feature in many word
processors is an example of a modeless dialog. Modeless dialogs have title bar
controls (close, minimize, and zoom buttons)."

Comment 14

[Greg K.]

Changing OS to OS X since that's what we care about now.

Comment 15

[Shawn Landres]

Properties window can be minimized (yellow button) but NOT closed (red button).
Clicking "OK" has no effect.

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Mass reassign of my non-Firefox bugs to [e-mail]

Comment 17

[tim.wood+bugzilla_mozilla]

This bug has never affected me as a user until Mozilla 1.7.  Under 1.7/OS X,
there are times when I do a File Bookmark (shift-command-D) and the resulting
dialog will not go away until I quit Mozilla.  Period.  I'm about to downgrade
to get around this one.

Comment 18

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 19

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 20

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 21

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 22

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 23

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 24

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 25

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420