Closed
Bug 1421312
Opened 7 years ago
Closed 7 years ago
Import buttons incorrectly wrap
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox57 | --- | unaffected |
| firefox58 | --- | verified |
| firefox59 | --- | verified |
People
(Reporter: Mardak, Assigned: andreio)
References
Details
(Keywords: regression)
User Story
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
Mardak
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
Regressed by bug 1413550 fixed by export bug 1415812.
https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93
|
Reporter | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•7 years ago
|
Keywords: regression
|
||
Updated•7 years ago
|
status-firefox57:
--- → unaffected
status-firefox-esr52:
--- → unaffected
|
|
Reporter | |
Comment 1•7 years ago
|
||
gchang says this bug has missed 58.0b8. It doesn't have a patch with beta approval flag. Please attach the appropriate patch without install.rdf.in changes and request approval ASAP.
Flags: needinfo?(andrei.br92)
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8933357 [details]
Bug 1421312 - Import buttons on activity Stream incorrectly wrap.
Approval Request Comment
[Feature/Bug causing the regression]: https://github.com/mozilla/activity-stream/commit/73ea6dc43a149fb9a31a0b23cd03d6a5b97d13e5
[User impact if declined]: minimal
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: incorrect button wrap on lower resolution devices. no steps required.
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: not risky. minimal css change.
[String changes made/needed]: none
Flags: needinfo?(andrei.br92)
Attachment #8933357 -
Flags: approval-mozilla-beta?
|
|
Reporter | |
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8933357 [details]
Bug 1421312 - Import buttons on activity Stream incorrectly wrap.
https://reviewboard.mozilla.org/r/204270/#review209884
Attachment #8933357 -
Flags: review?(edilee) → review+
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8933357 [details]
Bug 1421312 - Import buttons on activity Stream incorrectly wrap.
Fix an import buttons incorrectly wrap issue. Beta58+.
Attachment #8933357 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 6•7 years ago
|
||
| bugherder uplift | ||
|
|
Reporter | |
Updated•7 years ago
|
User Story: (updated)
|
|
Reporter | |
Updated•7 years ago
|
|
||
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: iulia.cristescu
|
||
Comment 7•7 years ago
|
||
I managed to reproduce the initial issue on 59.0a1 (2017-11-13). I also can confirm that 59.0a1 (2017-12-28) and 58.0b13 build1 (20171226085105) are verified fixed using Windows 10 x64, Windows 7 x86, Ubuntu 16.04 x64 and macOS 10.13.2.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•