Closed
Bug 1421441
Opened 7 years ago
Closed 7 years ago
Upgrade to React 16
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: dmosedale)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [strings landed][AS60MVP] )
Attachments
(1 file)
51.28 KB,
image/png
|
Details |
No description provided.
Reporter | ||
Updated•7 years ago
|
status-firefox58:
--- → wontfix
Reporter | ||
Updated•7 years ago
|
Iteration: 1.25 → 1.26
Assignee | ||
Comment 1•7 years ago
|
||
Bryan, here's a place to put or link to the mocks for error handling boxes...
Reporter | ||
Updated•7 years ago
|
Iteration: 1.26 → 1.27
Reporter | ||
Updated•7 years ago
|
Iteration: 1.27 → 60.1 - Jan 29
Comment 2•7 years ago
|
||
Here's a mock for an error state for the sections. The box styling should be the same that we use for zero-states, although, note that there's no icon in the box as not to draw too much attention. If the area needs to be shorter (i.e. Top Sites section) it can be the appropriate size for that section and the text should float in the middle.
Copy reads: "Oops, something went wrong loading this content. Refresh the page to try again."
The last line should be a link that reloads the page.
https://mozilla.invisionapp.com/share/YFFA2STTB#/272847648_New_Tab_-_Section_Error
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Updated•7 years ago
|
status-firefox60:
--- → affected
Updated•7 years ago
|
Whiteboard: [AS60MVP]
Reporter | ||
Updated•7 years ago
|
Iteration: 60.1 - Jan 29 → 60.2 - Feb 12
Assignee | ||
Comment 4•7 years ago
|
||
The pull request: https://github.com/mozilla/activity-stream/pull/3964
Comment 5•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/5e46ed45e4c021561503a2c1dd709dd60129932f
Merge pull request #3964 from dmose/2-react-16
Upgrade to React 16.2 and add error boundaries (fix bug 1421441)
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Target Milestone: --- → Firefox 60
Reporter | ||
Comment 6•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Whiteboard: [AS60MVP] → [strings needed][AS60MVP]
Reporter | ||
Comment 7•7 years ago
|
||
Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/11
Whiteboard: [strings needed][AS60MVP] → [strings landed][AS60MVP]
Updated•6 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•