Closed Bug 1421441 Opened 7 years ago Closed 6 years ago

Upgrade to React 16

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 60
Iteration:
60.2 - Feb 12
Tracking Status
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: Mardak, Assigned: dmosedale)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [strings landed][AS60MVP] )

Attachments

(1 file)

      No description provided.
See Also: → 1421823
Depends on: 1421424
Priority: P2 → P1
Blocks: 1421438
Depends on: 1421426
Depends on: 1423652
Depends on: 1422918
Iteration: 1.25 → 1.26
Bryan, here's a place to put or link to the mocks for error handling boxes...
Iteration: 1.26 → 1.27
Iteration: 1.27 → 60.1 - Jan 29
Here's a mock for an error state for the sections. The box styling should be the same that we use for zero-states, although, note that there's no icon in the box as not to draw too much attention. If the area needs to be shorter (i.e. Top Sites section) it can be the appropriate size for that section and the text should float in the middle.

Copy reads: "Oops, something went wrong loading this content. Refresh the page to try again." 

The last line should be a link that reloads the page.

https://mozilla.invisionapp.com/share/YFFA2STTB#/272847648_New_Tab_-_Section_Error
Attached image fonts.png
Whiteboard: [AS60MVP]
Iteration: 60.1 - Jan 29 → 60.2 - Feb 12
Blocks: 1426705
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5e46ed45e4c021561503a2c1dd709dd60129932f
Merge pull request #3964 from dmose/2-react-16

Upgrade to React 16.2 and add error boundaries (fix bug 1421441)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1435920
Target Milestone: --- → Firefox 60
Whiteboard: [AS60MVP] → [strings needed][AS60MVP]
Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/11
Whiteboard: [strings needed][AS60MVP] → [strings landed][AS60MVP]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: