Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Mardak, Assigned: dmose)

Tracking

(Blocks 1 bug)

Trunk
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 wontfix, firefox59 wontfix, firefox60 fixed)

Details

(Whiteboard: [strings landed][AS60MVP] , URL)

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
(Reporter)

Updated

2 years ago
See Also: → 1421823
(Assignee)

Updated

2 years ago
Depends on: 1421424
Priority: P2 → P1
(Assignee)

Updated

2 years ago
Blocks: 1421438
(Assignee)

Updated

2 years ago
Depends on: 1421426
(Assignee)

Updated

a year ago
Depends on: 1423652
(Assignee)

Updated

a year ago
Depends on: 1422918
(Reporter)

Updated

a year ago
Iteration: 1.25 → 1.26
Bryan, here's a place to put or link to the mocks for error handling boxes...
(Reporter)

Updated

a year ago
Iteration: 1.26 → 1.27
(Reporter)

Updated

a year ago
Iteration: 1.27 → 60.1 - Jan 29

Comment 2

a year ago
Here's a mock for an error state for the sections. The box styling should be the same that we use for zero-states, although, note that there's no icon in the box as not to draw too much attention. If the area needs to be shorter (i.e. Top Sites section) it can be the appropriate size for that section and the text should float in the middle.

Copy reads: "Oops, something went wrong loading this content. Refresh the page to try again." 

The last line should be a link that reloads the page.

https://mozilla.invisionapp.com/share/YFFA2STTB#/272847648_New_Tab_-_Section_Error

Comment 3

a year ago
Posted image fonts.png
(Reporter)

Updated

a year ago
Whiteboard: [AS60MVP]
(Reporter)

Updated

a year ago
Iteration: 60.1 - Jan 29 → 60.2 - Feb 12
(Assignee)

Updated

a year ago
Blocks: 1426705

Comment 5

a year ago
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5e46ed45e4c021561503a2c1dd709dd60129932f
Merge pull request #3964 from dmose/2-react-16

Upgrade to React 16.2 and add error boundaries (fix bug 1421441)

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Reporter)

Updated

a year ago
Blocks: 1435920
Target Milestone: --- → Firefox 60
(Reporter)

Updated

a year ago
Whiteboard: [AS60MVP] → [strings needed][AS60MVP]
(Reporter)

Comment 7

a year ago
Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/11
Whiteboard: [strings needed][AS60MVP] → [strings landed][AS60MVP]
You need to log in before you can comment on or make changes to this bug.