Closed Bug 1426705 Opened 2 years ago Closed 2 years ago

Add responsive layout, React 16 and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Iteration:
60.2 - Feb 12
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: dmose, Assigned: dmose)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/9be4c3c684e68a666502be167c83aa8dbe428f06...a77359dcf84a51216cdb80122bd3e3250f014aec

Attachments

(3 files)

Soon, we'll be exporting a version of activity-stream from github which will use React 16.  This uses the MIT license, rather than the license used in previous versions of react.  I'll be attaching a patch to update license.html to add this license.
Note that I've left the old React license, because other projects in the tree (eg devtools, screenshots) are still using older versions.
Comment on attachment 8938428 [details]
Bug 1426705 - update license.html to include React MIT license from React 16,

https://reviewboard.mozilla.org/r/209132/#review214902
Attachment #8938428 - Flags: review?(gerv) → review+
Iteration: --- → 1.27
Priority: -- → P2
Severity: normal → enhancement
Iteration: 1.27 → 60.1 - Jan 29
Iteration: 60.1 - Jan 29 → 60.2 - Feb 12
Whiteboard: [AS60MVP]
Depends on: 1421441
User Story: (updated)
Depends on: 1435419, 1429489, 1435863
Summary: activity-stream export from github with React 16 → Add React 16 ... and bug fixes to Activity Stream
Depends on: 1435920
Depends on: 1385944, 1436145
User Story: (updated)
Assignee: nobody → dmose
Summary: Add React 16 ... and bug fixes to Activity Stream → Add responsive layout, React 16 and bug fixes to Activity Stream
User Story: (updated)
Comment on attachment 8949842 [details]
Bug 1426705 - Add responsive layout, React 16 and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/219158/#review224934

Thanks!
Attachment #8949842 - Flags: review?(usarracini) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c7207731ee1
update license.html to include React MIT license from React 16, r=gerv
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/47b8cc3b625e
Add responsive layout, React 16 and bug fixes to Activity Stream. r=ursula
Hrmm.. https://searchfox.org/mozilla-central/source/browser/installer/allowed-dupes.mn
# PLEASE DO NOT ADD MORE EXCEPTIONS TO THIS LIST

ERROR: The following duplicated files are not allowed:
browser/features/activity-stream@mozilla.org/chrome/content/vendor/react-dev.js
browser/chrome/devtools/modules/devtools/client/shared/vendor/react-dev.js
Flags: needinfo?(dmose)
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/22f78ddb5720
Add responsive layout, React 16 and bug fixes to Activity Stream. r=ursula
Turns out devtools landed react 16.2.0 to autoland in bug 1416824 just a few hours before we tried. After chatting on #devtools and #developers, sounds like devtools typically has customizations in their react file, but we happen to have the exact same version right now. It sounded desirable to make sure each consumer can change and upgrade on their own schedule, so we added a comment to our react-dev file to avoid duplication failure.
Flags: needinfo?(dmose)
See Also: → 1416824
https://hg.mozilla.org/mozilla-central/rev/9c7207731ee1
https://hg.mozilla.org/mozilla-central/rev/22f78ddb5720
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Gained some performance improvement thanks to this!

== Change summary for alert #11492 (as of Fri, 09 Feb 2018 21:30:02 GMT) ==

Improvements:

  2%  sessionrestore_many_windows windows10-64 pgo e10s stylo     1,273.46 -> 1,245.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11492
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/54e47e81cf154d7199d121d584571987525c964d
chore(mc): Port Bug 1426705 - Add responsive layout, React 16 and bug fixes to Activity Stream. r=ursula (#3985)
Blocks: 1438821
Depends on: 1470417
Depends on: 1439840
Whiteboard: [AS60MVP] → [export]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.