1426705 - Add responsive layout, React 16 and bug fixes to Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Soon, we'll be exporting a version of activity-stream from github which will use React 16.  This uses the MIT license, rather than the license used in previous versions of react.  I'll be attaching a patch to update license.html to add this license.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1426705 - update license.html to include React MIT license from React 16,

Review commit: https://reviewboard.mozilla.org/r/209132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209132/

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Note that I've left the old React license, because other projects in the tree (eg devtools, screenshots) are still using older versions.

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 8938428 [details]
Bug 1426705 - update license.html to include React MIT license from React 16,

https://reviewboard.mozilla.org/r/209132/#review214902

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1426705 - Add responsive layout, React 16 and bug fixes to Activity Stream.

Review commit: https://reviewboard.mozilla.org/r/219158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219158/

Comment 5

[Ursula Sarracini (:ursula)]

Comment on attachment 8949842 [details]
Bug 1426705 - Add responsive layout, React 16 and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/219158/#review224934

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c7207731ee1
update license.html to include React MIT license from React 16, r=gerv

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47b8cc3b625e
Add responsive layout, React 16 and bug fixes to Activity Stream. r=ursula

Comment 8

[Arthur Iakab [arthur_iakab]]

Backed out changeset 47b8cc3b625e (bug 1426705) for build bustage on a CLOSED TREE
Link to the failing log: https://treeherder.mozilla.org/logviewer.html#?job_id=161407186&repo=autoland&lineNumber=28945
Backout revision 9c9278be5c97
Failing push https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=47b8cc3b625ef2f270d37c9d8e4565d384be982d

Comment 9

[Ed Lee :Mardak]

Hrmm.. https://searchfox.org/mozilla-central/source/browser/installer/allowed-dupes.mn
# PLEASE DO NOT ADD MORE EXCEPTIONS TO THIS LIST

ERROR: The following duplicated files are not allowed:
browser/features/[e-mail]/chrome/content/vendor/react-dev.js
browser/chrome/devtools/modules/devtools/client/shared/vendor/react-dev.js

Comment 10

[Ed Lee :Mardak]

Comment on attachment 8949842 [details]
Bug 1426705 - Add responsive layout, React 16 and bug fixes to Activity Stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219158/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22f78ddb5720
Add responsive layout, React 16 and bug fixes to Activity Stream. r=ursula

Comment 12

[Ed Lee :Mardak]

Turns out devtools landed react 16.2.0 to autoland in bug 1416824 just a few hours before we tried. After chatting on #devtools and #developers, sounds like devtools typically has customizations in their react file, but we happen to have the exact same version right now. It sounded desirable to make sure each consumer can change and upgrade on their own schedule, so we added a comment to our react-dev file to avoid duplication failure.

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9c7207731ee1
https://hg.mozilla.org/mozilla-central/rev/22f78ddb5720

Comment 14

[Ionuț Goldan [:igoldan]]

Gained some performance improvement thanks to this!

== Change summary for alert #11492 (as of Fri, 09 Feb 2018 21:30:02 GMT) ==

Improvements:

  2%  sessionrestore_many_windows windows10-64 pgo e10s stylo     1,273.46 -> 1,245.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11492

Comment 15

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3985

Comment 16

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/54e47e81cf154d7199d121d584571987525c964d
chore(mc): Port Bug 1426705 - Add responsive layout, React 16 and bug fixes to Activity Stream. r=ursula (#3985)