1421518 - Add an automation test for new autoplay policy

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Alastor Wu [:alwu]]

Will add a chrome-browser test to ensure the play() can start or fail on different user-gestures scenario.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1421518 - add user-gestures test for the autoplay policy.

Mouse click or keyboard press are the events which could activate the page and allow
the page to autoplay.

Other events are not.

Review commit: https://reviewboard.mozilla.org/r/203774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203774/

Comment 2

[Alastor Wu [:alwu]]

Comment on attachment 8932724 [details]
Bug 1421518 - add user-gestures test for the autoplay policy.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203774/diff/1-2/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8932724 [details]
Bug 1421518 - add user-gestures test for the autoplay policy.

https://reviewboard.mozilla.org/r/203774/#review210432

::: toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js:59
(Diff revision 2)
> +  info("- can't autoplay without user activation -");
> +  await canplayPromise;
> +  ok(video.paused, "video can't start without user input.");
> +
> +  info("- call play() without user activation -");
> +  await video.play().catch(function() {

You don't need 'await' if you want to call .then() or .catch() on a promise.

::: toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js:84
(Diff revision 2)
> +  info("- can't autoplay without user activation -");
> +  await canplayPromise;
> +  ok(video.paused, "video can't start without user input.");
> +
> +  info("- call play() without user activation -");
> +  await video.play().catch(function() {

This test is already done in test_play_without_user_gesture(). You don't need to duplicate the test here.

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8932724 [details]
Bug 1421518 - add user-gestures test for the autoplay policy.

https://reviewboard.mozilla.org/r/203774/#review210450

::: toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js:59
(Diff revision 2)
> +  info("- can't autoplay without user activation -");
> +  await canplayPromise;
> +  ok(video.paused, "video can't start without user input.");
> +
> +  info("- call play() without user activation -");
> +  await video.play().catch(function() {

That awit is used to keep the code running in correct sequence. If you remove it, the catch might be executed after removeTab().

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8932724 [details]
Bug 1421518 - add user-gestures test for the autoplay policy.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203774/diff/2-3/

Comment 6

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a6334c3f8b9df90721e60ab6fd53c71fc19d88e

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 8932724 [details]
Bug 1421518 - add user-gestures test for the autoplay policy.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203774/diff/3-4/

Comment 8

[Alastor Wu [:alwu]]

Comment on attachment 8932724 [details]
Bug 1421518 - add user-gestures test for the autoplay policy.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203774/diff/4-5/

Comment 9

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ac66f1d827a003402810a674e389f707846b36b&selectedJob=149482855

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/213ae1ab70d4
add user-gestures test for the autoplay policy. r=jwwang

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/213ae1ab70d4