1424113 - Remove CPOWs objects from autoplay tests

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Alastor Wu [:alwu]]

In bug1421518 and bug1420488, I added some tests which is using the CPOWs object.
Howevet, DOM team's folk told me that CPOWs should not suppose to be used anymore, I need to be replace them with ContentTask.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1424113 - remove CPOWs objects from autoplay tests.

Review commit: https://reviewboard.mozilla.org/r/211272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211272/

Comment 2

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7257da5e7b0bbdea24774ec850b60bbc0e7802a3

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8940993 [details]
Bug 1424113 - remove CPOWs objects from autoplay tests.

You'll need a review from a toolkit peer on this. I can only review stuff from the devtools module.
See https://wiki.mozilla.org/Modules/All#Toolkit

Comment 4

[Alastor Wu [:alwu]]

(In reply to Patrick Brosset <:pbro> from comment #3)
> Comment on attachment 8940993 [details]
> Bug 1424113 - remove CPOWs objects from autoplay tests.
> 
> You'll need a review from a toolkit peer on this. I can only review stuff
> from the devtools module.
> See https://wiki.mozilla.org/Modules/All#Toolkit

OK, I'll find a toolkit peer and ask for a review, thanks you!

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8940993 [details]
Bug 1424113 - remove CPOWs objects from autoplay tests.

https://reviewboard.mozilla.org/r/211272/#review217762

::: toolkit/content/tests/browser/browser.ini:17
(Diff revision 1)
>    file_mediaPlaybackFrame.html
>    file_mediaPlaybackFrame2.html
>    file_multipleAudio.html
>    file_multiplePlayingAudio.html
>    file_nonAutoplayAudio.html
> +  file_video.html

Please make this and gizmo.mp4 support files for browser_autoplay_policy_play_twice.js and browser_autoplay_policy_user_gestures.js explicitly, rather than for all tests.

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8940993 [details]
Bug 1424113 - remove CPOWs objects from autoplay tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211272/diff/1-2/

Comment 7

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19124600aba55e1954b7a39bf123e9a621b95bf6

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9517df1f4b1b
remove CPOWs objects from autoplay tests. r=dao

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9517df1f4b1b