Closed Bug 1424113 Opened 3 years ago Closed 2 years ago

Remove CPOWs objects from autoplay tests

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

Details

Attachments

(1 file)

In bug1421518 and bug1420488, I added some tests which is using the CPOWs object.
Howevet, DOM team's folk told me that CPOWs should not suppose to be used anymore, I need to be replace them with ContentTask.
Priority: -- → P3
Attachment #8940993 - Flags: review?(pbrosset)
Comment on attachment 8940993 [details]
Bug 1424113 - remove CPOWs objects from autoplay tests.

You'll need a review from a toolkit peer on this. I can only review stuff from the devtools module.
See https://wiki.mozilla.org/Modules/All#Toolkit
(In reply to Patrick Brosset <:pbro> from comment #3)
> Comment on attachment 8940993 [details]
> Bug 1424113 - remove CPOWs objects from autoplay tests.
> 
> You'll need a review from a toolkit peer on this. I can only review stuff
> from the devtools module.
> See https://wiki.mozilla.org/Modules/All#Toolkit

OK, I'll find a toolkit peer and ask for a review, thanks you!
Attachment #8940993 - Flags: review?(pbrosset) → review?(rchien)
Attachment #8940993 - Flags: review?(rchien) → review?(dao+bmo)
Comment on attachment 8940993 [details]
Bug 1424113 - remove CPOWs objects from autoplay tests.

https://reviewboard.mozilla.org/r/211272/#review217762

::: toolkit/content/tests/browser/browser.ini:17
(Diff revision 1)
>    file_mediaPlaybackFrame.html
>    file_mediaPlaybackFrame2.html
>    file_multipleAudio.html
>    file_multiplePlayingAudio.html
>    file_nonAutoplayAudio.html
> +  file_video.html

Please make this and gizmo.mp4 support files for browser_autoplay_policy_play_twice.js and browser_autoplay_policy_user_gestures.js explicitly, rather than for all tests.
Attachment #8940993 - Flags: review?(dao+bmo) → review+
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9517df1f4b1b
remove CPOWs objects from autoplay tests. r=dao
https://hg.mozilla.org/mozilla-central/rev/9517df1f4b1b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.