1421538 - Set country field to default country when creating new addresses

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement)

Description

[Scott Wu [:scottwu]]

When adding new address, we could populate the country field with default country (if it's supported). This would avoid a scenario described in bug 1421217, where the default country has hidden fields (ex. Germany). The user might be confused when trying to enter a US address and couldn't find the State field.

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1421538 - Set country field to default country when creating new addresses.

Review commit: https://reviewboard.mozilla.org/r/210078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210078/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8939769 [details]
Bug 1421538 - Set country field to default country when creating new addresses.

https://reviewboard.mozilla.org/r/210078/#review216092

::: browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:5
(Diff revision 1)
>  "use strict";
>  
>  add_task(async function test_cancelEditAddressDialog() {
> -  await new Promise(resolve => {
> -    let win = window.openDialog(EDIT_ADDRESS_DIALOG_URL);
> +  await testDialog(EDIT_ADDRESS_DIALOG_URL, win => {
> +    let doc = win.document;

A redundant line?

::: browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:22
(Diff revision 1)
> +  SpecialPowers.pushPrefEnv({set: [[DEFAULT_REGION_PREF, "CA"]]});
> +  await testDialog(EDIT_ADDRESS_DIALOG_URL, win => {
> +    let doc = win.document;
> +    is(doc.querySelector("#country").value, "CA",
> +                         "Default country set to Canada");
> +    win.document.querySelector("#cancel").click();

nit: How about `doc.querySelector(...` if `doc` exists.

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8939769 [details]
Bug 1421538 - Set country field to default country when creating new addresses.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210078/diff/1-2/

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8939769 [details]
Bug 1421538 - Set country field to default country when creating new addresses.

https://reviewboard.mozilla.org/r/210078/#review216092

Thanks Luke! Fixed the issues and a few eslint problems.

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 8939769 [details]
Bug 1421538 - Set country field to default country when creating new addresses.

Looks good, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ea106a104bb
Set country field to default country when creating new addresses. r=lchang

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9ea106a104bb