1421802 - Don't show the New Tab doorhanger if an extension was already installed

Status: RESOLVED WORKSFORME

(WebExtensions :: Frontend, enhancement)

Description

[Mark Striemer [:mstriemer]]

If you have a New Tab extension installed and you update to a version of Nightly with the New Tab doorhanger, you'll see the doorhanger on your first New Tab.

I'm guessing we only want the doorhanger to appear after a user installs a New Tab extension, so it shouldn't show in this case. Is that what you would expect, Markus?

Comment 1

[Kris Maglione [:kmag]]

I think arguably we may want to show the door hanger to users who have never seen it for an add-on they already have installed. Though, again arguably, that should probably happen on Firefox update rather than extension update.

Comment 2

[Mark Striemer [:mstriemer]]

Currently if you've never approved the changes and you update Nightly you'll see the doorhanger. Updating the extension should have no bearing on it.

I see both sides to this. I found it odd when I saw the doorhanger since I already had a New Tab extension and there didn't seem to be any action that I took to make it appear. But also, if I had installed the extension a very long time ago and didn't realise it was overriding the default New Tab maybe a little nudge would be nice to allow me to make that decision.

Comment 3

[Markus Jaritz [:designakt] (UX)]

I think we should still show it in those cases on the first newTab people see after a Firefox update...
This way those people also get to choose what newTab they want.
(I am saying this, knowing that this might cost some extension some users, but believe that in those cases, those users did not fully intentional choose to have their newTab replaced, or forgot about it, and are happy to go back.)
(As I think this affects more than UX, I also reached out to Kev, for him to voice concerns if he does not agree with that decision)

Comment 4

[Mark Striemer [:mstriemer]]

Okay, ni? on kev to get approval on closing this bug then.

Comment 5

[Kev Needham [:kev]]

Agree with Markus.