Closed
Bug 1421902
Opened 7 years ago
Closed 6 years ago
Some tests have random JavaScript Error: "Failed to load tippy top manifest from "
Categories
(Firefox :: New Tab Page, defect, P2)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Seems like various tests (non-activity-stream?) seem to be causing FaviconFeed to reportError: linux 64 debug: bc4 https://queue.taskcluster.net/v1/task/YHy9Q9ItQV-QQ1TetFAb9w/runs/0/artifacts/public/logs/live_backing.log bc15 https://queue.taskcluster.net/v1/task/Io2aucbNRxWl8B5gkBN3yw/runs/0/artifacts/public/logs/live_backing.log Console message: [JavaScript Error: "Failed to load tippy top manifest from " {file: "resource://activity-stream/lib/FaviconFeed.jsm" line: 85}] loadFromURL@resource://activity-stream/lib/FaviconFeed.jsm:85:7 async*refresh@resource://activity-stream/lib/FaviconFeed.jsm:54:38 async*maybeRefresh@resource://activity-stream/lib/FaviconFeed.jsm:45:13 async*getSitesByDomain/this._sitesByDomain<@resource://activity-stream/lib/FaviconFeed.jsm:106:13 async*getSitesByDomain@resource://activity-stream/lib/FaviconFeed.jsm:104:58 fetchIcon@resource://activity-stream/lib/FaviconFeed.jsm:116:33 async*onAction@resource://activity-stream/lib/FaviconFeed.jsm:142:9 _middleware/</<@resource://activity-stream/lib/Store.jsm:51:11 Store/this[method]@resource://activity-stream/lib/Store.jsm:30:55 _requestRichIcon@resource://activity-stream/lib/TopSitesFeed.jsm:189:5 _fetchIcon@resource://activity-stream/lib/TopSitesFeed.jsm:174:7 async*getLinksWithDefaults@resource://activity-stream/lib/TopSitesFeed.jsm:134:9 async*refresh@resource://activity-stream/lib/TopSitesFeed.jsm:153:25 async*onAction@resource://activity-stream/lib/TopSitesFeed.jsm:263:9 async*_middleware/</<@resource://activity-stream/lib/Store.jsm:51:11 Store/this[method]@resource://activity-stream/lib/Store.jsm:30:55 init/this.intervalId<@resource://activity-stream/lib/SystemTickFeed.jsm:19:41 notify@resource://gre/modules/Timer.jsm:44:7 I guess the tests are running long enough to trigger a 5 minute tick as well as having links in history? We should clean things up to avoid others being confused about seeing the message and thinking something is broken.
Updated•7 years ago
|
Comment 1•6 years ago
|
||
Is the fix here simply to not report the error if the url is empty string? Something as simple as: --- a/system-addon/lib/FaviconFeed.jsm +++ b/system-addon/lib/FaviconFeed.jsm @@ -82,7 +82,9 @@ this.FaviconFeed = class FaviconFeed { etag = response.headers.get("ETag"); } } catch (error) { - Cu.reportError(`Failed to load tippy top manifest from ${url}`); + if (url !=== "") { + Cu.reportError(`Failed to load tippy top manifest from ${url}`); + } } return {data, etag, status}; } Or?
Assignee | ||
Comment 2•6 years ago
|
||
I might take this as part of fixing bug 1423506 to turn off stuff.
Assignee | ||
Comment 3•6 years ago
|
||
Just jotting down for reference some tests that run in the set that has the error messages: > https://queue.taskcluster.net/v1/task/YHy9Q9ItQV-QQ1TetFAb9w/runs/0/artifacts/public/logs/live_backing.log browser/components/customizableui/test/browser_sidebar_toggle.js | took 2548ms browser/components/customizableui/test/browser_synced_tabs_menu.js | took 12216ms browser/components/customizableui/test/browser_widget_animation.js | took 2852ms > https://queue.taskcluster.net/v1/task/Io2aucbNRxWl8B5gkBN3yw/runs/0/artifacts/public/logs/live_backing.log browser/components/extensions/test/browser/browser_ext_windows_events.js | took 5635ms browser/components/extensions/test/browser/browser_ext_windows_size.js | took 12375ms browser/components/extensions/test/browser/browser_ext_windows_update.js | took 6602ms And the latest pine with bug 1423506 doesn't seem to have the errors: customizableui: https://public-artifacts.taskcluster.net/PRweuw1rRS2QoT2RJaTKxw/0/public/logs/live_backing.log extensions: https://public-artifacts.taskcluster.net/SIKO0ZbwTz-DmsBPJX3dCQ/0/public/logs/live_backing.log The former logs do have bug 1413078 getScreenshot messages though. Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/f0e1304ce05e16a8a0592f029b7d9462d5a43222 fix(favicons): Check endpoint and site_icons prefs before fetching icons (#3898) Fix Bug 1423506 - Tippytop does not honor preference browser.chrome.site_icons
Assignee: nobody → edilee
Status: NEW → RESOLVED
Iteration: 1.26 → 1.25
Closed: 6 years ago
Resolution: --- → FIXED
See Also: → 1423506
Assignee | ||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75910829e890
Target Milestone: --- → Firefox 59
Assignee | ||
Comment 5•6 years ago
|
||
Oops, this was actually fixed by bug 1423506 https://hg.mozilla.org/mozilla-central/rev/b41233cc2b97
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•