class EnterLeaveDispatcher is declared twice

RESOLVED FIXED in Firefox 59

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sylvestre, Assigned: maiquynhtruong, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [good first bug][lang=C++])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
A trivial good first bug to understand the workflows.

found by clang-tidy "no definition found for 'EnterLeaveDispatcher', but a definition with the same name 'EnterLeaveDispatcher' found in another namespace 'mozilla'"

The first declaration can be removed.
(Reporter)

Updated

a year ago
Blocks: 1422628
(Assignee)

Comment 1

a year ago
I'll try to take a stab on this.

Do you mean removing the line: https://searchfox.org/mozilla-central/source/dom/events/EventStateManager.h#29 ?
(Reporter)

Comment 2

a year ago
Indeed!

Please submit a patch for this!
Comment hidden (mozreview-request)
(Reporter)

Updated

a year ago
Assignee: nobody → maitruong2801
(Reporter)

Comment 4

a year ago
Comment on attachment 8934409 [details]
Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher.

Good, you should now find the official reviewer!
Attachment #8934409 - Flags: review?(sledru) → feedback+
(Assignee)

Comment 5

a year ago
(In reply to Sylvestre Ledru [:sylvestre] from comment #4)
> Comment on attachment 8934409 [details]
> Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher.
> 
> Good, you should now find the official reviewer!

I'll probably need help with this. How do I find the official reviewers? I looked at the change log (https://hg.mozilla.org/mozilla-central/log/tip/dom/events/EventStateManager.cpp) and there are multiple people making changes to the file. Can I choose anyone of them?

Thanks!
(Reporter)

Comment 6

a year ago
First, you should look at https://wiki.mozilla.org/Modules/All to find out who are the official reviewers of this component.
Just look for "dom/events" on this page!
(Assignee)

Updated

a year ago
Attachment #8934409 - Flags: review?(sledru)
Attachment #8934409 - Flags: review?(masayuki)
Attachment #8934409 - Flags: review?(bugs)
(Reporter)

Comment 7

a year ago
Comment on attachment 8934409 [details]
Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher.

One reviewer is enough!
Attachment #8934409 - Flags: review?(sledru)
Attachment #8934409 - Flags: review?(bugs)
Comment on attachment 8934409 [details]
Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher.

https://reviewboard.mozilla.org/r/205328/#review212180
Attachment #8934409 - Flags: review?(masayuki) → review+

Comment 9

a year ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c03e9d114143
Remove redundant declarion of class EnterLeaveDispatcher. r=masayuki

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c03e9d114143
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.