Closed
Bug 1422626
Opened 7 years ago
Closed 7 years ago
class EnterLeaveDispatcher is declared twice
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: maiquynhtruong, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][lang=C++])
Attachments
(1 file)
A trivial good first bug to understand the workflows. found by clang-tidy "no definition found for 'EnterLeaveDispatcher', but a definition with the same name 'EnterLeaveDispatcher' found in another namespace 'mozilla'" The first declaration can be removed.
|
Assignee | |
Comment 1•7 years ago
|
||
I'll try to take a stab on this. Do you mean removing the line: https://searchfox.org/mozilla-central/source/dom/events/EventStateManager.h#29 ?
|
Reporter | |
Comment 2•7 years ago
|
||
Indeed! Please submit a patch for this!
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → maitruong2801
|
|
Reporter | |
Comment 4•7 years ago
|
||
Comment on attachment 8934409 [details] Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher. Good, you should now find the official reviewer!
Attachment #8934409 -
Flags: review?(sledru) → feedback+
|
|
Assignee | |
Comment 5•7 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #4) > Comment on attachment 8934409 [details] > Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher. > > Good, you should now find the official reviewer! I'll probably need help with this. How do I find the official reviewers? I looked at the change log (https://hg.mozilla.org/mozilla-central/log/tip/dom/events/EventStateManager.cpp) and there are multiple people making changes to the file. Can I choose anyone of them? Thanks!
|
|
Reporter | |
Comment 6•7 years ago
|
||
First, you should look at https://wiki.mozilla.org/Modules/All to find out who are the official reviewers of this component. Just look for "dom/events" on this page!
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8934409 -
Flags: review?(sledru)
Attachment #8934409 -
Flags: review?(masayuki)
Attachment #8934409 -
Flags: review?(bugs)
|
|
Reporter | |
Comment 7•7 years ago
|
||
Comment on attachment 8934409 [details] Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher. One reviewer is enough!
Attachment #8934409 -
Flags: review?(sledru)
Attachment #8934409 -
Flags: review?(bugs)
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8934409 [details] Bug 1422626 - Remove redundant declarion of class EnterLeaveDispatcher. https://reviewboard.mozilla.org/r/205328/#review212180
Attachment #8934409 -
Flags: review?(masayuki) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c03e9d114143 Remove redundant declarion of class EnterLeaveDispatcher. r=masayuki
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c03e9d114143
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•