1422628 - enable bugprone-forward-declaration-namespace in the static analysis

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

No false positive, improve the code, let's enable it:
http://clang.llvm.org/extra/clang-tidy/checks/bugprone-forward-declaration-namespace.html
Just on occurrence in our code and there is no false positive.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1422628 - enable bugprone-forward-declaration-namespace in the static analysis

Review commit: https://reviewboard.mozilla.org/r/204930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204930/

Comment 2

[Andi [:andi]]

Comment on attachment 8934015 [details]
Bug 1422628 - enable bugprone-forward-declaration-namespace in the static analysis

https://reviewboard.mozilla.org/r/204930/#review210542

This one is very interesting, can you please post where it found the issue in Gecko, I'm pretty curious to see if it really has an impact.

Comment 3

[Andi [:andi]]

Per my earlier comment: No need I found it:
https://bugzilla.mozilla.org/show_bug.cgi?id=1422626

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edfc1bd98a5d
enable bugprone-forward-declaration-namespace in the static analysis r=andi

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/edfc1bd98a5d