Closed Bug 1422735 Opened 2 years ago Closed 2 years ago

Change symbol upload URL from Socorro to Tecken

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox-esr5258+ fixed, firefox57 wontfix, firefox58 fixed, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 58+ fixed
firefox57 --- wontfix
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

peterbe has split symbol handling out of Socorro into a standalone service called Tecken: https://github.com/mozilla-services/tecken/

It's live serving symbols.mozilla.org right now, but we're still uploading symbols via Socorro's symbol upload API. We'd like to switch over uploads to Tecken. This should be as simple as just changing the upload URL to https://symbols.mozilla.org/upload/ here:
https://dxr.mozilla.org/mozilla-central/rev/574f4f58fe09dd590ea892406e237318c31705b4/toolkit/crashreporter/tools/upload_symbols.py#28
See Also: → 1422737
Depends on: 1422740
Assignee: nobody → ted
The patch in bug 1422740 got a little more complicated than I expected and it doesn't really block this change, so I just wrote the one-line patch to change the upload URL instead. This should be simple to land whenever we're ready and easy to uplift across branches.
No longer depends on: 1422740
Comment on attachment 8934934 [details]
bug 1422735 - Change symbol upload URL from Socorro to Tecken.

https://reviewboard.mozilla.org/r/205864/#review211648

Technically fine, and I'm confident you'll follow whatever policy is required.  Verified URL at https://github.com/mozilla-services/tecken/blob/8eb9143276fbdc422ed27e1990a19cf1d9bcdb76/docs/upload.rst.
Attachment #8934934 - Flags: review+
Attachment #8934934 - Flags: review?(core-build-config-reviews)
Pushed by tmielczarek@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04f52fb15e76
Change symbol upload URL from Socorro to Tecken. r=nalexander
Blocks: 1423881
https://hg.mozilla.org/mozilla-central/rev/04f52fb15e76
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Blocks: 1424334
When we originally landed this patch we broke nightly symbol uploads (bug 1424236) because the tokens that were migrated from Socorro to Tecken didn't get their permissions migrated with them, so Tecken refused the uploads. We worked around this on central by landing my patches in bug 1422740 to use a token from a Taskcluster secret, and I generated a new token in Tecken to use there. Since then peterbe fixed the migrated tokens (bug 1424326), so we'd like to land this small patch on all other branches so that all symbol uploads are going through Tecken.
Comment on attachment 8934934 [details]
bug 1422735 - Change symbol upload URL from Socorro to Tecken.

Per my previous comment, we've had symbol uploads going through Tecken on central for about a month now, and we'd like to switch other branches over so we can eventually EOL the Socorro symbol upload API.

This patch is a single line that changes the symbol upload URL. It does not affect the shipped builds, but could impact crash reporting if symbols fail to upload. We do not expect any issues from switching the upload URL.
Attachment #8934934 - Flags: approval-mozilla-release?
Attachment #8934934 - Flags: approval-mozilla-esr52?
Attachment #8934934 - Flags: approval-mozilla-beta?
Comment on attachment 8934934 [details]
bug 1422735 - Change symbol upload URL from Socorro to Tecken.

Take this to change symbol upload URL. Beta58+ & ESR52+.
Attachment #8934934 - Flags: approval-mozilla-esr52?
Attachment #8934934 - Flags: approval-mozilla-esr52+
Attachment #8934934 - Flags: approval-mozilla-beta?
Attachment #8934934 - Flags: approval-mozilla-beta+
Comment on attachment 8934934 [details]
bug 1422735 - Change symbol upload URL from Socorro to Tecken.

58 is on mozilla-release now, so we won't be making that change to 57.
Attachment #8934934 - Flags: approval-mozilla-release? → approval-mozilla-release-
Gotcha, thanks!
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.