Closed Bug 1422846 Opened 2 years ago Closed 2 years ago

donottrack.xul seems to be unused

Categories

(Firefox :: Preferences, enhancement, P5)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: johannh, Assigned: nevetia.vedant, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(2 files)

There appears to be a dialog for setting the "Do Not Track" attribute which was added in bug 1231375, but it doesn't seem to be used anywhere.

This function opens it:
https://searchfox.org/mozilla-central/rev/477ac066b565ae0eb3519875581a62dfb1430e98/browser/components/preferences/in-content/privacy.js#630

But AFAICS the function is never called.

I presume this got lost in the preferences re-org.
Mentor: jaws, jhofmann
Keywords: good-first-bug
Priority: -- → P5
Hi Johann,

I'd like to be able to work on this. Could I get some more information to understand where this attribute can be used?

Thanks
Vedant
Hi Vedant, this bug is about removing the donottrack.xul file and all places where it is mentioned (https://searchfox.org/mozilla-central/search?q=donottrack.xul&path=).
Assignee: nobody → nevetia.vedant
Status: NEW → ASSIGNED
Comment on attachment 8935028 [details] [diff] [review]
remove all occurences of donottrack.xul

Review of attachment 8935028 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!
Attachment #8935028 - Flags: review+
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b950d180e68
remove all occurences of donottrack.xul r=jaws
Keywords: checkin-needed
Looks like I left out a file that I was supposed to get rid of. Sorry about that :NarcisB, I will look into this and resubmit a fixed patch.
Flags: needinfo?(nevetia.vedant)
If I need to run these tests and make sure everything is good before submitting the patch, how can I do so?


Thank you
Vedant
Flags: needinfo?(jhofmann)
(In reply to Vedant from comment #8)
> If I need to run these tests and make sure everything is good before
> submitting the patch, how can I do so?
> 
> 
> Thank you
> Vedant

Sorry for the delay, you will need access to our Try Server (https://wiki.mozilla.org/ReleaseEngineering/TryServer), but I'm happy to push the patch to try for you, if you upload it again :)
Flags: needinfo?(jhofmann)
I have created a new patch with the changes that I think should fix whatever was causing the test to fail. please let me know how it goes
Ah, sorry, I forgot about this while traveling. Try looks good, let's get it checked in.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b7f5d0ef7fa
Remove all occurences of donottrack.xul and donottrack.dtd. r=johannh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2b7f5d0ef7fa
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Depends on: 1593462
You need to log in before you can comment on or make changes to this bug.