1422846 - donottrack.xul seems to be unused

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

There appears to be a dialog for setting the "Do Not Track" attribute which was added in bug 1231375, but it doesn't seem to be used anywhere.

This function opens it:
https://searchfox.org/mozilla-central/rev/477ac066b565ae0eb3519875581a62dfb1430e98/browser/components/preferences/in-content/privacy.js#630

But AFAICS the function is never called.

I presume this got lost in the preferences re-org.

Comment 1

[Vedant]

Hi Johann,

I'd like to be able to work on this. Could I get some more information to understand where this attribute can be used?

Thanks
Vedant

Comment 2

[Johann Hofmann [:johannh]]

Hi Vedant, this bug is about removing the donottrack.xul file and all places where it is mentioned (https://searchfox.org/mozilla-central/search?q=donottrack.xul&path=).

Comment 3

[Vedant]

Attachment: remove all occurences of donottrack.xul

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8935028 [details] [diff] [review]
remove all occurences of donottrack.xul

Review of attachment 8935028 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b950d180e68
remove all occurences of donottrack.xul r=jaws

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for browser-chrome failures on browser_all_files_referenced.js

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d285451ccc319bab74eeda2193d140b5a7c980c
https://treeherder.mozilla.org/logviewer.html#?job_id=150762862&repo=mozilla-inbound&lineNumber=1964

Comment 7

[Vedant]

Looks like I left out a file that I was supposed to get rid of. Sorry about that :NarcisB, I will look into this and resubmit a fixed patch.

Comment 8

[Vedant]

If I need to run these tests and make sure everything is good before submitting the patch, how can I do so?


Thank you
Vedant

Comment 9

[Johann Hofmann [:johannh]]

(In reply to Vedant from comment #8)
> If I need to run these tests and make sure everything is good before
> submitting the patch, how can I do so?
> 
> 
> Thank you
> Vedant

Sorry for the delay, you will need access to our Try Server (https://wiki.mozilla.org/ReleaseEngineering/TryServer), but I'm happy to push the patch to try for you, if you upload it again :)

Comment 10

[Vedant]

Attachment: Fix - remove all occurences of donottrack.xul and donottrack.dtd

Comment 11

[Vedant]

I have created a new patch with the changes that I think should fix whatever was causing the test to fail. please let me know how it goes

Comment 12

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70f602a8696b571abde12b4a8d306821ee273550

Comment 13

[Johann Hofmann [:johannh]]

Ah, sorry, I forgot about this while traveling. Try looks good, let's get it checked in.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b7f5d0ef7fa
Remove all occurences of donottrack.xul and donottrack.dtd. r=johannh

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2b7f5d0ef7fa