1423172 - Useless major vs minor update distinction in the update UI

Status: RESOLVED WONTFIX

(Toolkit :: Application Update, enhancement, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Follow up from 406738

To quote Florian:
Note: the major vs minor update distinction is still exposed in the update UI with these strings https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/toolkit/locales/en-US/chrome/mozapps/update/updates.properties#20-21,38-41,65-66 shown by https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/toolkit/mozapps/update/content/updates.js#649

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1423172 - Remove some useless strings in the updater

Review commit: https://reviewboard.mozilla.org/r/207004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207004/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

I kept the _major strings. I am not sure how renaming of key in properties files works for localization purposes.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8936243 [details]
Bug 1423172 - Remove some useless strings in the updater

https://reviewboard.mozilla.org/r/207004/#review216224

I wonder if we should go ahead and completely remove the type attribute: https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/toolkit/mozapps/update/nsIUpdateService.idl#89-95

It's referenced at:
https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/toolkit/mozapps/update/nsUpdateService.js#1352
https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/toolkit/mozapps/update/nsUpdateService.js#1481
https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/toolkit/mozapps/update/nsUpdateService.js#2159-2160,2177-2195
Warning: this file deals with another type attribute that's about complete vs partial updates.

::: toolkit/locales/en-US/chrome/mozapps/update/updates.properties
(Diff revision 1)
>  # %1$S is the brandShortName. Ex: MyApplication
>  # %2$S is the update version - provided by the update xml. Ex: version 10.0.5
>  # %3$S is the build identifier - provided by the update xml. Ex: 20081022033543
>  updateNightlyName=%1$S %2$S %3$S nightly
> -intro_major=Do you want to upgrade to %1$S %2$S now?
> -intro_minor=A security and stability update for %1$S is available:

You are removing both strings here, but this is still used at https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/toolkit/mozapps/update/content/updates.js#667

::: toolkit/locales/en-US/chrome/mozapps/update/updates.properties
(Diff revision 1)
>  updateNightlyName=%1$S %2$S %3$S nightly
> -intro_major=Do you want to upgrade to %1$S %2$S now?
> -intro_minor=A security and stability update for %1$S is available:
>  
>  updateType_major=New Version
> -updateType_minor=Security Update

You already removed these 2 strings in bug 406738.

::: toolkit/locales/en-US/chrome/mozapps/update/updates.properties
(Diff revision 1)
>  askLaterButton.accesskey=A
>  noThanksButton=No Thanks
>  noThanksButton.accesskey=N
> -updateButton_minor=Update %S
> -updateButton_minor.accesskey=U
> -updateButton_major=Get the New Version

You are still using this string, aren't you?

::: toolkit/mozapps/update/content/updates.js:652
(Diff revision 1)
>     * Initialize
>     */
>    onPageShow() {
>      gUpdates.wiz.canRewind = false;
>      var update = gUpdates.update;
> -    gUpdates.setButtons("askLaterButton", null, "updateButton_" + update.type,
> +    gUpdates.setButtons("askLaterButton", null, "updateButton_major",

nit: this can now fit on a single 80 chars line.

::: toolkit/mozapps/update/content/updates.js:667
(Diff revision 1)
>                                            update.buildID]);
>      }
>      var updateNameElement = document.getElementById("updateName");
>      updateNameElement.value = updateName;
>  
>      var introText = gUpdates.getAUSString("intro_" + update.type,

Do you want to change this too?

::: toolkit/mozapps/update/content/updates.js:670
(Diff revision 1)
>      updateNameElement.value = updateName;
>  
>      var introText = gUpdates.getAUSString("intro_" + update.type,
>                                            [gUpdates.brandName, update.displayVersion]);
>      var introElem = document.getElementById("updatesFoundInto");
>      introElem.setAttribute("severity", update.type);

Is this still relevant? This severity attribute doesn't seem referenced anywhere.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

This should still be done but I don't have time to work on that.

There should be enough information in this bug for a potential contributor

Comment 5

[Robert Strong (they/them - no direct email)]

This UI will be removed in bug 1515484 so resolving as wontfix