Closed Bug 1423307 Opened 6 years ago Closed 6 years ago

Update Windows clang-cl builds to a newer upstream LLVM version to fix bustage with VS2017 15.5


(Firefox Build System :: General, enhancement)

Not set


(firefox59 fixed)

Tracking Status
firefox59 --- fixed


(Reporter: RyanVM, Assigned: RyanVM)


(Depends on 1 open bug)



(1 file)

With the current 5.0.0svn version we're bootstrapping, we hit a build failure with the new VC++ v14.12 toolset shipping in VS2017 15.5:

error: '_Ty' does not refer to a value

Which in turns leads to a Rust panic and build failure.

I've confirmed locally that updating to SVN tip (r319785) fixes this failure and allows me to build again. I'll work on cleaning up the patch a bit and more thoroughly test it with all our different build variants so we can make this the new default and unblock Visual Studio upgrades.
As an update, I tried a build off SVN rev 317840 (same as what we're using for Linux ASAN builds), and while it mostly seems to work OK on Try (and successfully builds m-c locally), I'm seeing Win32 static analysis build failures:

Win64 builds are fine. Newer SVN revisions hit other static analysis bustage in clang-plugin.dll, but dmajor has a tentative fix that I'll try pushing on top of tomorrow.
This is the same revision we're currently using for Linux ASAN builds. Confirmed locally that this fixes the build issues with VS2017 15.5.
Attachment #8935054 - Flags: review?(core-build-config-reviews)
Depends on: 1423667
Attachment #8935054 - Flags: review?(core-build-config-reviews) → review+
Pushed by
Update clang-cl builds to LLVM revision 317840. r=ted
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1425983
Depends on: 1425984
Depends on: 1440983
Product: Core → Firefox Build System
See Also: → 1456057
You need to log in before you can comment on or make changes to this bug.