1423551 - Use BaseRect methods instead of directly member variables in view/

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1423551: Use BaseRect access methods instead of member variables in view/.

Review commit: https://reviewboard.mozilla.org/r/205884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205884/

Comment 2

[Jet Villegas (inactive)]

Comment on attachment 8934944 [details]
Bug 1423551: Use BaseRect access methods instead of member variables in view/.

https://reviewboard.mozilla.org/r/205884/#review212166

Comment 3

[Jet Villegas (inactive)]

BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it says:
https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361

If there's any doubt, please seek further review. Thanks!

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8934944 [details]
Bug 1423551: Use BaseRect access methods instead of member variables in view/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205884/diff/1-2/

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Jet Villegas (:jet) from comment #3)
> BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it
> says:
> https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361

It does!  I ran some perf tests (in other cases) that confirmed this.  Just doing inline doesn't guarantee it.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc9c67be2c523a47554cedab957e831946065afe

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/744a3f069aec
Use BaseRect access methods instead of member variables in view/. r=jet

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/744a3f069aec