Use BaseRect methods instead of directly member variables in view/

RESOLVED FIXED in Firefox 59

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: milan, Assigned: milan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Comment hidden (empty)
Assignee: nobody → milan
Blocks: 1386277
Comment hidden (mozreview-request)
Priority: -- → P3
Whiteboard: [gfx-noted]
Blocks: 1423919
No longer blocks: 1386277

Comment 2

a year ago
mozreview-review
Comment on attachment 8934944 [details]
Bug 1423551: Use BaseRect access methods instead of member variables in view/.

https://reviewboard.mozilla.org/r/205884/#review212166
Attachment #8934944 - Flags: review?(bugs) → review+
BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it says:
https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361

If there's any doubt, please seek further review. Thanks!
Comment hidden (mozreview-request)
(In reply to Jet Villegas (:jet) from comment #3)
> BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it
> says:
> https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361

It does!  I ran some perf tests (in other cases) that confirmed this.  Just doing inline doesn't guarantee it.

Comment 7

a year ago
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/744a3f069aec
Use BaseRect access methods instead of member variables in view/. r=jet

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/744a3f069aec
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.