Closed Bug 1423551 Opened 3 years ago Closed 3 years ago
Rect methods instead of directly member variables in view/
59 bytes, text/x-review-board-request
No description provided.
Assignee: nobody → milan
Priority: -- → P3
Comment on attachment 8934944 [details] Bug 1423551: Use BaseRect access methods instead of member variables in view/. https://reviewboard.mozilla.org/r/205884/#review212166
Attachment #8934944 - Flags: review?(bugs) → review+
BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it says: https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361 If there's any doubt, please seek further review. Thanks!
Depends on: 1428348
(In reply to Jet Villegas (:jet) from comment #3) > BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it > says: > https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361 It does! I ran some perf tests (in other cases) that confirmed this. Just doing inline doesn't guarantee it.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/744a3f069aec Use BaseRect access methods instead of member variables in view/. r=jet
You need to log in before you can comment on or make changes to this bug.