Closed
Bug 1423551
Opened 6 years ago
Closed 6 years ago
Use BaseRect methods instead of directly member variables in view/
Categories
(Core :: Graphics, enhancement, P3)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: milan, Assigned: milan)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: [gfx-noted]
Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8934944 [details] Bug 1423551: Use BaseRect access methods instead of member variables in view/. https://reviewboard.mozilla.org/r/205884/#review212166
Attachment #8934944 -
Flags: review?(bugs) → review+
Comment 3•6 years ago
|
||
BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it says: https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361 If there's any doubt, please seek further review. Thanks!
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Jet Villegas (:jet) from comment #3) > BTW, I gave this the r+ assuming MOZ_ALWAYS_INLINE will always do what it > says: > https://searchfox.org/mozilla-central/source/gfx/2d/BaseRect.h#361 It does! I ran some perf tests (in other cases) that confirmed this. Just doing inline doesn't guarantee it.
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc9c67be2c523a47554cedab957e831946065afe
Pushed by msreckovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/744a3f069aec Use BaseRect access methods instead of member variables in view/. r=jet
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/744a3f069aec
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•