1428348 - Let Set{Right,Left,Bottom,Top}Edge set negative width/height

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

There is currently no checks for rectangle height and width being set to only non-negative numbers, and we have code that clearly assumes those values are allowed (at least temporarily).  Remove the asserts from the Set{Right,Left,Bottom,Top}Edge methods that trigger if the width/height are set to a negative value to make things consistent.

If we decide that the negative values should never be allowed, we need to make larger changes.  With these asserts, we're discouraging the use of these convenient methods, instead forcing callers to compute and set the width and height directly.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1428348: Allow Set{Left,Right,Top,Bottom}Edge methods to compute negative width/height without asserting. .schouten

Review commit: https://reviewboard.mozilla.org/r/210522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210522/

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8940208 [details]
Bug 1428348: Allow Set{Left,Right,Top,Bottom}Edge methods to compute negative width/height without asserting. .schouten

https://reviewboard.mozilla.org/r/210522/#review217156

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8940208 [details]
Bug 1428348: Allow Set{Left,Right,Top,Bottom}Edge methods to compute negative width/height without asserting. .schouten

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210522/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe793fde1117
Allow Set{Left,Right,Top,Bottom}Edge methods to compute negative width/height without asserting. r=bas.schouten

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fe793fde1117