Closed Bug 1423558 Opened 2 years ago Closed 2 years ago

Use BaseRect methods instead of directly member variables in docshell/

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: milan, Assigned: milan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

No description provided.
Assignee: nobody → milan
Blocks: 1386277
Priority: -- → P3
Whiteboard: [gfx-noted]
Comment on attachment 8934949 [details]
Bug 1423558: Use BaseRect access methods instead of member variables in docshell

https://reviewboard.mozilla.org/r/205896/#review211456

All looks good to me but I'm not a peer so redirecting to Samael.

::: commit-message-79d3e:1
(Diff revision 1)
> +Bug 1423558: Use rectangles access methods instead of member variables. r?overholt

s/rectangles/rectangle's/, maybe?
Attachment #8934949 - Flags: review?(overholt) → review?(sawang)
Comment on attachment 8934949 [details]
Bug 1423558: Use BaseRect access methods instead of member variables in docshell

https://reviewboard.mozilla.org/r/205894/#review211682
Comment on attachment 8934949 [details]
Bug 1423558: Use BaseRect access methods instead of member variables in docshell

https://reviewboard.mozilla.org/r/205894/#review211684
Comment on attachment 8934949 [details]
Bug 1423558: Use BaseRect access methods instead of member variables in docshell

I don't quite understand why I didn't see r+ on mozreview, but it's a r+ anyway.
Attachment #8934949 - Flags: review?(sawang) → review+
Comment on attachment 8934949 [details]
Bug 1423558: Use BaseRect access methods instead of member variables in docshell

https://reviewboard.mozilla.org/r/205896/#review211698
Oh great. Got it.
Blocks: 1423919
No longer blocks: 1386277
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72da6def61e0
Use BaseRect access methods instead of member variables in docshell r=freesamael
https://hg.mozilla.org/mozilla-central/rev/72da6def61e0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.