1423591 - On Walmart.com the "First/Last name on card" shouldn't be treated as a different section

Status: RESOLVED INVALID

(Toolkit :: Form Autofill, defect)

Description

[ovidiu boca[:Ovidiu]]

Affected versions]:

Tested on Nightly 59.0a1(2017-12-05)

[Affected platforms]:

Tested on Mac 10.13 10.11 Windows 10, 7 and Ubuntu 16.04

[Steps to reproduce]:

Prerequisites:
 1. Make sure you have at least two saved profiles.

 
1. Go to www.walmart.com and login 
2. Go to your account -> Update your credit card details -> Add a new credit/debit card
3. Use the autofill to fill in the "First name" 
4. Fill in the section "card number"
5. Go back to "First name" field and click on it

[Expected result]:

A drop down with 2 buttons is shown. On Windows, you have "Clear Form" and "More Options" and on Mac and Linux you have "Clear Form" and "Preferences".

[Actual result]:

The "Clear Form" button is not displayed. 

Note: Please see the video for the actual result: https://streamable.com/nn1u1

Comment 1

[ovidiu boca[:Ovidiu]]

Please note that this bug is reproducible only if you follow the steps in the exact order.

Comment 2

[Ray Lin[:ralin]]

I can reproduce the problem intermittently, maybe its a timing issue for focused input. NI myself, I'll look closer to this.

Comment 3

[Ray Lin[:ralin]]

The cause is because the form modification force the later focus drop all the states of filled section. We should figure out better section re-construction strategy instead of directly replacing with newly identified field details.

Comment 4

[Luke Chang [:lchang] (inactive)]

Per comment 3, it appears to be a more generic bug related to section support. I'll file another bug for tracking.

Regarding walmart.com, however, there is still a compatible issue related to the card holder name, which shouldn't be treated as a different section. Therefore, I'd like to change the title of this bug and focus on the heuristics problem here.

Comment 5

[Luke Chang [:lchang] (inactive)]

Bug 1427956 was filed.

Comment 6

[Ray Lin[:ralin]]

The markdown of "First name on card" field: 

<input value="" name="firstName" title="First name" autocomplete="section-payment given-name" maxlength="25" data-automation-id="firstName-cc" data-tl-id="first-name0" aria-label="First name on card" id="firstName" aria-invalid="false" class="form-control form-control--without-icon">

By seeing, it's apparently the name field belongs to credit card section and should be identified as "cc-given-name" instead of "given name". On the other side, if we 100% respect the autocomplete attribute, current result is expected as "given-name" is explicitly set to input. 

Chrome gets similar results like ours, so I guess this is a known issue for other browsers as well. And it seems to me that fixing this would bring more bad than good in most of other cases.

Comment 7

[Luke Chang [:lchang] (inactive)]

Per comment 6, this bug is caused by the incorrect use of @autocomplete. Agree with Ray that we should respect the standard, which means this bug can't and doesn't need to be fixed. Therefore, close it as INVALID.

Comment 8

[Sean Lee [:seanlee][:weilonge]]

Attachment: State Field

The state field in the credit card page of Walmart.com is misused to `autocomplete="section-shipping region"`, so it should be `autocomplete="section-shipping address-level1"`.

It's worth to inform them of the issues of "card holder name" and "state".