Closed Bug 1423696 Opened 2 years ago Closed 2 years ago

Inset box-shadows render incorrectly in some cases

Categories

(Core :: Graphics: WebRender, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox59 --- affected

People

(Reporter: mstange, Assigned: ethlin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-mvp] [triage])

Attachments

(3 files)

Attached file testcase
In this testcase, with WebRender enabled, the element's clip also seems to clip the pre-blur shadow shape, instead of just clipping the blurred result.
Whiteboard: [wr-mvp] [triage]
Assignee: nobody → ethlin
Depends on: 1426116
Comment on attachment 8940587 [details]
Bug 1423696 - Update the reftest annotations after we fixed the webrender box shadow problem(issue #2261).

https://reviewboard.mozilla.org/r/210796/#review216610

This is fine but I'm going to move it to bug 1426116 since it needs to land together with the WR update
Attachment #8940587 - Flags: review?(bugmail) → review+
This landed in bug 1426116, is there anything else that needs to be done here? If not we can close this bug.
The inset box shadow test case I added in bug 1423633 attachment 8940252 [details] is still broken (the rendering, not just the slow scrolling). The right and bottom lines don't appear at all.
(In reply to Andrew Osmond [:aosmond] from comment #5)
> The inset box shadow test case I added in bug 1423633 attachment 8940252 [details]
> [details] is still broken (the rendering, not just the slow scrolling). The
> right and bottom lines don't appear at all.

I'm going to close this bug. I think we should create another bug for bug 1423633 attachment 8940252 [details].
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
I agree, this bug as filed is fixed.
Attached video 2018-01-10_11-29-40.mp4
Nightly 59 x64 20180109234707 de_DE @ Debian Testing (Radeon RX480)
fresh profile: layers.acceleration.force-enabled, gfx.webrender.enabled, gfx.webrender.blob-images, image.mem.shared

attachment 8935091 [details]

I wouldn't call this as (completely) fixed.
I've filed bug 1429411 for one of the cases shown in the video.
Sorry, I didn't know the size also effects the result. Let me take the bug 1429411.
You need to log in before you can comment on or make changes to this bug.