1423696 - Inset box-shadows render incorrectly in some cases

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Markus Stange [:mstange]]

Attachment: testcase

In this testcase, with WebRender enabled, the element's clip also seems to clip the pre-blur shadow shape, instead of just clipping the blurred result.

Comment 1

[Ethan Lin[:ethlin]]

PR: https://github.com/servo/webrender/pull/2261

According to the try push[1], I should update the reftest.list. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=aac72b3488afd74fce9afcd4edf7ce17763bd57e&selectedJob=154326187

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Bug 1423696 - Update the reftest annotations after we fixed the webrender box shadow problem(issue #2261).

Review commit: https://reviewboard.mozilla.org/r/210796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210796/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8940587 [details]
Bug 1423696 - Update the reftest annotations after we fixed the webrender box shadow problem(issue #2261).

https://reviewboard.mozilla.org/r/210796/#review216610

This is fine but I'm going to move it to bug 1426116 since it needs to land together with the WR update

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This landed in bug 1426116, is there anything else that needs to be done here? If not we can close this bug.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

The inset box shadow test case I added in bug 1423633 attachment 8940252 [details] is still broken (the rendering, not just the slow scrolling). The right and bottom lines don't appear at all.

Comment 6

[Ethan Lin[:ethlin]]

(In reply to Andrew Osmond [:aosmond] from comment #5)
> The inset box shadow test case I added in bug 1423633 attachment 8940252 [details]
> [details] is still broken (the rendering, not just the slow scrolling). The
> right and bottom lines don't appear at all.

I'm going to close this bug. I think we should create another bug for bug 1423633 attachment 8940252 [details].

Comment 7

[Markus Stange [:mstange]]

I agree, this bug as filed is fixed.

Comment 8

[Darkspirit]

Attachment: 2018-01-10_11-29-40.mp4

Nightly 59 x64 20180109234707 de_DE @ Debian Testing (Radeon RX480)
fresh profile: layers.acceleration.force-enabled, gfx.webrender.enabled, gfx.webrender.blob-images, image.mem.shared

attachment 8935091 [details]

I wouldn't call this as (completely) fixed.

Comment 9

[Markus Stange [:mstange]]

I've filed bug 1429411 for one of the cases shown in the video.

Comment 10

[Ethan Lin[:ethlin]]

Sorry, I didn't know the size also effects the result. Let me take the bug 1429411.