1423814 - av1: backport ssse3 alignment fix

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Ralph Giles (:rillian)]

Backport the fix :dmajor found for the 32-bit crash in libaom and re-enable the decoder on 32-bit platforms.

We plan to pull a new upstream revision including this soon, so just applying the patch in-tree is fine.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1423814 - av1: Fix simd alignment on 32-bit x86.

Thanks to David Major for crash analysis and finding the fix.

Backport of upstream commit 15269e6e9288a6ed655c2ee73be6fbb4e0ea3cf5
by Yaowu Xu <[e-mail]>	Mon Oct 16 10:48:55 2017 -0700

Align more restoration work buffers

Fixes crashes on x86-win32-vs14 build

Change-Id: I045dd0fe4e9af3bfb80223e291617b717cbcb231

Review commit: https://reviewboard.mozilla.org/r/206128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206128/

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1423814 - av1: re-enable decoder on 32-bit nightly.

Revert the work-around from bug 1421635 now that the upstream
fix is applied.

Review commit: https://reviewboard.mozilla.org/r/206130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206130/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8935245 [details]
Bug 1423814 - av1: Fix simd alignment on 32-bit x86.

https://reviewboard.mozilla.org/r/206128/#review211732

::: build/moz.configure/rust.configure:49
(Diff revision 1)
>          VERSION_FORMAT = r'^cargo (\d\.\d+\.\d+).*'
>  
>          m = re.search(VERSION_FORMAT, out[0])
>          # Fail fast if cargo changes its output on us.
>          if not m:
>              die('Could not determine cargo version from output: %s', out)

Wrong patch attached?

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8935246 [details]
Bug 1423814 - av1: re-enable decoder on 32-bit nightly.

https://reviewboard.mozilla.org/r/206130/#review211734

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8935245 [details]
Bug 1423814 - av1: Fix simd alignment on 32-bit x86.

https://reviewboard.mozilla.org/r/206128/#review211746

::: build/moz.configure/rust.configure:49
(Diff revision 1)
>          VERSION_FORMAT = r'^cargo (\d\.\d+\.\d+).*'
>  
>          m = re.search(VERSION_FORMAT, out[0])
>          # Fail fast if cargo changes its output on us.
>          if not m:
>              die('Could not determine cargo version from output: %s', out)

Certainly explains why the try push failed!

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8935245 [details]
Bug 1423814 - av1: Fix simd alignment on 32-bit x86.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206128/diff/1-2/

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8935246 [details]
Bug 1423814 - av1: re-enable decoder on 32-bit nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206130/diff/1-2/

Comment 8

[Matthew Gregan [:kinetik]]

Comment on attachment 8935245 [details]
Bug 1423814 - av1: Fix simd alignment on 32-bit x86.

https://reviewboard.mozilla.org/r/206128/#review211966

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14058397c000
av1: Fix simd alignment on 32-bit x86. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/f6fc1c2c4cef
av1: re-enable decoder on 32-bit nightly. r=kinetik

Comment 10

[(Away)]

Ionuț: This will undo the effect of bug 1421635 comment 16, which was not a "real" improvement as the code was removed for crashing.

Comment 11

[Ionuț Goldan [:igoldan]]

Oh, cool! Thanks for pointing this out!

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14058397c000
https://hg.mozilla.org/mozilla-central/rev/f6fc1c2c4cef