Closed Bug 1424350 Opened 3 years ago Closed 3 years ago

TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_datetime.js (caused by bug 1401528)

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorgk-bmo, Assigned: Fallen)

References

Details

(Whiteboard: [Thunderbird-temporary-fix])

Attachments

(2 files)

TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_datetime.js | really_run_test - [really_run_test : 77] "America/New_York" == "America/New York" 

See bug 1401528 comment #144 and bug 1401528 comment #151.
I was playing with this a bit.
I do not have any hints yet, but I found one odd case.

The test uses the timezoneService a lot, @mozilla.org/calendar/timezone;1 .

This service is NOT unregistered in calBackendLoader.js, but it is mentioned in icaljs-manifest of services that would be registered instead of their libical counterparts. How does that work?

Also in calTimezone.js there are 2 implementations of a timezoneService, calICALJSTimezone and calLibicalTimezone, both having the same contractID. In calTimezoneService.js it is decided at runtime which of these versions are called, depending on "calendar.icaljs". Why is this done this way and the service is not cleanly overriden in calBackendLoader.js as the other ones? It may be some of these games do not work with sharedGlobal==true, it is more picky with overriding services and freezing Cc[contractId] results.
Keywords: leave-open
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/db576aeb2b0e
temporarily disable failing test_datetime.js. rs=bustage-fix
Whiteboard: [Thunderbird-temporary-fix]
Blocks: ltn62
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attached patch Fix - v1Splinter Review
This takes care. The original global was shared between files, which it is now now, so it goes into the catch block and just uses the tzid.
Attachment #8942529 - Flags: review?(makemyday)
Comment on attachment 8942529 [details] [diff] [review]
Fix - v1

Review of attachment 8942529 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good. r=me
Attachment #8942529 - Flags: review?(makemyday) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8035dbacafd4
Move string bundle from global to service to fix string errors. r=MakeMyDay
Thanks, Philipp!
Fixed in Calendar 6.1 which corresponds with TB 59 where bug 1401528 was landed.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 6.1
Attachment #8935882 - Attachment description: 1424350-disable-test_datetime.patch → 1424350-disable-test_datetime.patch (temporary fix removed in comment #6)
You need to log in before you can comment on or make changes to this bug.