1424631 - Update webrender to 1142dfc557c319119a5117450718c5b67a93cb9f

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1424280 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 700ac281d8257e84cdde21bf6eb603bbb734f1c0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80c474d19047f9663df900eeb4b6f204f4d924d0
https://treeherder.mozilla.org/#/jobs?repo=try&revision=48977da49aa92588b78f6da5a3099727af4166e9

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 2844ef2006fd1fe2c4ff77ff434906624e14f5ff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19ed90bd70b61d3d1689a9c7107f9268caac0fc9
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0aa7bfd285a627f78c9d1f05a61289f8b36724d4

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ 2844ef2006fd1fe2c4ff77ff434906624e14f5ff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c5c8993f3185b7fab8957db2bf9b3805c1123f3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4f8554ba8d0306872920544fe47dbf023eb3fa8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9f46dae27223a3f78f8f84ef15ff49ab849673a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=093d779719f7a5c773700952f6ddeb77b19745f1

Green

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 2844ef2006fd1fe2c4ff77ff434906624e14f5ff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e51635bda1d553a820daba42b021213be5dc71ff
https://treeherder.mozilla.org/#/jobs?repo=try&revision=03646b50b771a363b1235091ec460d4cfd741446
https://treeherder.mozilla.org/#/jobs?repo=try&revision=445ab64905c253fda0579d4d1ee2dbd97839497c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31ad0839ec27d76df5290830bd2a8e1c37b106e6

Green

WR @ 67f7e0edeabba6861250922d47f8c6a1b2232d4b

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7faa6727ccb95f358eb80b52ee02a7f5f5d66ced
https://treeherder.mozilla.org/#/jobs?repo=try&revision=97f1956da9dace2264091af116d07b1f70a69055

Green

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 67f7e0edeabba6861250922d47f8c6a1b2232d4b

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7156c2738916b744d9c6c64d830d8aa46b57683b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d40989516821f8e74c5ab5a1f70010f7dd3f07

Green

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ 67f7e0edeabba6861250922d47f8c6a1b2232d4b

https://treeherder.mozilla.org/#/jobs?repo=try&revision=644d7d5792bc6f80f7525722162ab41fc61cd6ec
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5d1c589531d7d0759b2462d900b3b3a2cec577e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2449bb4f57412ae0861f7b37f9638c80e9e23724
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98651642862bf40acf92ffc182cd8fc26b854eea

Green

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 67f7e0edeabba6861250922d47f8c6a1b2232d4b

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54984500d71ba6bd928a93eae736b7622d384030
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba971d0d2b66f8c9dfe44a7fc38ab56d506e967b

Green

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ d333859dbd81d8cc7dd44b6b4c66565383d440b1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1608b1c61a681ba5cfb594d68bad7666e9c1b2aa
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4a39bfffce04ba3a1d2d8546cdadc129ec37ebb

Green

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ c16b37dd3dee05283156e17c75e4e1b77a5d23c4

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc2cdff9ea5054eccea8263e48c22ac71aae64d3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a22409923b3ebfb1458025d3309df5f94a45fd5

Green

Comment 10

[Kartikaya Gupta (email:[e-mail])]

WR @ 2633873e13737dbf522266fa066f4de15f3d2c50

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdec6ba8740023e52f215eb5e4de60369074d623
https://treeherder.mozilla.org/#/jobs?repo=try&revision=73b4b4f24d946672687f8b74625f8bd61739f388

Green

WR @ 2633873e13737dbf522266fa066f4de15f3d2c50

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&fromchange=1f9f128ae9cf78278d18154f71327628695149d9&group_state=expanded&tochange=d2357be1bfe62abab334582d22fcaa07cc053be1

Basically green. Some random oranges, and the SM-tc(p) and SM-tc(cgc) jobs went red at some point but I think that's from bug 1377007 so I left a comment there.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

WR @ 2633873e13737dbf522266fa066f4de15f3d2c50

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2aab76907a16032b5dcec72e8bdbeafb78e7c2b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d9ca5687f7df165a36be26c60a9c0603049f439

Same as before

Comment 12

[Kartikaya Gupta (email:[e-mail])]

WR @ 1142dfc557c319119a5117450718c5b67a93cb9f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ecdb3ad1b1058e7ecb4cac7d595e7ce0b45e621
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec61b3b85390cfe76445c7310d2b03630d3304f2

R3 failure, an already-fuzzy test changed from (70, 1320) to (68, 1440). Seems minor, I'll update the fuzz. That's a change from:

*   1142dfc5 Auto merge of #2233 - lsalzman:color-emoji-test, r=glennw
|\
| * 1e2ab6ca add reftest for color emoji fast shadows
* |   a40b78d3 Auto merge of #2229 - glennw:bs-overlap, r=kvark
|\ \
| |/
|/|
| * f8738133 Fix box shadows when the shadow rect is smaller than the nine-patch.
* 7ccc2eaa Auto merge of #2223 - lsalzman:emoji-zero-shadow, r=glennw
* 887c0d61 ignore glyph color data when doing fast shadows

so probably servo/webrender#2229.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1424631 - Update webrender to commit 1142dfc557c319119a5117450718c5b67a93cb9f.

Review commit: https://reviewboard.mozilla.org/r/208410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208410/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1424631 - Update reftest fuzziness for change in WR PR 2229.

Review commit: https://reviewboard.mozilla.org/r/208412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208412/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Oh also WR @ 1142dfc557c319119a5117450718c5b67a93cb9f from this morning:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=086d49a832716fc48c3ad23c0bf732fab2c59da8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b7b3d22246f2509a61c5ee322aef15242035513

Same WR cset, but all the debug builds are red. Not sure what that's about but it's probably something on the gecko side. I'll look into it.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Yeah the debug build bustage happened on m-c too and has been fixed, so we can ignore it.

Comment 17

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8937697 [details]
Bug 1424631 - Update webrender to commit 1142dfc557c319119a5117450718c5b67a93cb9f.

https://reviewboard.mozilla.org/r/208410/#review214158

Comment 18

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8937698 [details]
Bug 1424631 - Update reftest fuzziness for change in WR PR 2229.

https://reviewboard.mozilla.org/r/208412/#review214160

Comment 19

[Kartikaya Gupta (email:[e-mail])]

These landed, but I guess pulsebot wasn't able to post since bugzilla was intermittently down

https://hg.mozilla.org/integration/autoland/rev/16240aca46cbdcc67b48e5f47bfc92ef852a3e70
https://hg.mozilla.org/integration/autoland/rev/f232ff38a0c68e5cd26bd7fafa0a7474671effdc

Comment 20

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/16240aca46cb
https://hg.mozilla.org/mozilla-central/rev/f232ff38a0c6