Closed Bug 1424631 Opened 2 years ago Closed 2 years ago

Update webrender to 1142dfc557c319119a5117450718c5b67a93cb9f

Categories

(Core :: Graphics: WebRender, enhancement, P3)

59 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve] [gfx-noted])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1424280 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Whiteboard: [wr-reserve] [gfx-noted] → [wr-mvp] [gfx-noted]
Whiteboard: [wr-mvp] [gfx-noted] → [wr-reserve] [gfx-noted]
WR @ 1142dfc557c319119a5117450718c5b67a93cb9f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ecdb3ad1b1058e7ecb4cac7d595e7ce0b45e621
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec61b3b85390cfe76445c7310d2b03630d3304f2

R3 failure, an already-fuzzy test changed from (70, 1320) to (68, 1440). Seems minor, I'll update the fuzz. That's a change from:

*   1142dfc5 Auto merge of #2233 - lsalzman:color-emoji-test, r=glennw
|\
| * 1e2ab6ca add reftest for color emoji fast shadows
* |   a40b78d3 Auto merge of #2229 - glennw:bs-overlap, r=kvark
|\ \
| |/
|/|
| * f8738133 Fix box shadows when the shadow rect is smaller than the nine-patch.
* 7ccc2eaa Auto merge of #2223 - lsalzman:emoji-zero-shadow, r=glennw
* 887c0d61 ignore glyph color data when doing fast shadows

so probably servo/webrender#2229.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to 1142dfc557c319119a5117450718c5b67a93cb9f
Version: unspecified → 59 Branch
Oh also WR @ 1142dfc557c319119a5117450718c5b67a93cb9f from this morning:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=086d49a832716fc48c3ad23c0bf732fab2c59da8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b7b3d22246f2509a61c5ee322aef15242035513

Same WR cset, but all the debug builds are red. Not sure what that's about but it's probably something on the gecko side. I'll look into it.
Yeah the debug build bustage happened on m-c too and has been fixed, so we can ignore it.
Comment on attachment 8937697 [details]
Bug 1424631 - Update webrender to commit 1142dfc557c319119a5117450718c5b67a93cb9f.

https://reviewboard.mozilla.org/r/208410/#review214158
Attachment #8937697 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8937698 [details]
Bug 1424631 - Update reftest fuzziness for change in WR PR 2229.

https://reviewboard.mozilla.org/r/208412/#review214160
Attachment #8937698 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/16240aca46cb
https://hg.mozilla.org/mozilla-central/rev/f232ff38a0c6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Blocks: 1425157
Blocks: 1423603
Blocks: 1423692
Blocks: 1423683
You need to log in before you can comment on or make changes to this bug.