1430063 - regression: Specific wikipedia page: Only part of chart legend visible with WebRender

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Tobias (:Tobbi) Markus]

Steps to reproduce:
0. Enable webrender.

1. Go to https://de.wikipedia.org/wiki/Flensburg#Ratsversammlung and scroll until you see the chart "Sitzverteilung in der Ratsversammlung"

2. Notice that the upper part of the legend doesn't get shown. You only see 
Wählen! : 0
WiF: 6
FDP: 2
CDU: 10

The upper part with 
Linke: 2
SPD: 9
Grüne: 5
SSW: 8

is rendered behind what seems to be a white surface

Comment 1

[Darkspirit]

Danke!

https://de.wikipedia.org/wiki/Flensburg#Ratsversammlung
OT: The Website jumps down after a moment. This seems to be a bug of Wikipedia. (Can't reproduce with Chromium, but with Firefox ESR. wtf)


good = the bottom line of the canvas(?) flickers softly when scrolling


first regression: long lines, get drawn on chrome when scrolling
mozregression --good 2017-11-01 --bad 2018-01-10 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://de.wikipedia.org/wiki/Flensburg#Ratsversammlung"
> 12:13.54 INFO: Last good revision: 9cd0e864b61325db4a27327da47444cd9197cea1
> 12:13.54 INFO: First bad revision: f232ff38a0c68e5cd26bd7fafa0a7474671effdc
> 12:13.54 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9cd0e864b61325db4a27327da47444cd9197cea1&tochange=f232ff38a0c68e5cd26bd7fafa0a7474671effdc

> 16240aca46cb	Kartikaya Gupta — Bug 1424631 - Update webrender to commit 1142dfc557c319119a5117450718c5b67a93cb9f. r=jrmuizel


second regression: white area hides the upper half of labels, pie diagram gets drawn on chrome when scrolling
mozregression --good 2017-12-20 --bad 2018-01-10 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://de.wikipedia.org/wiki/Flensburg#Ratsversammlung"
> 8:18.96 INFO: Last good revision: c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4
> 8:18.96 INFO: First bad revision: 8ccb0e9d9bbeeed7d7e4474849debd7d21b65971
> 8:18.96 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4&tochange=8ccb0e9d9bbeeed7d7e4474849debd7d21b65971

> da9b75fc0866	Kartikaya Gupta — Bug 1426116 - Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e. r=jrmuizel

Comment 2

[Darkspirit]

Attachment: Screenshot_20180112_132104.png

good
screenshot: 20171101220120

first regression
screenshot: 20171224220321

second regression
screenshot: 20180109234707

Comment 3

[Kartikaya Gupta (email:[e-mail])]

first regression is due to:

* c16b37dd Auto merge of #2228 - glennw:overlap-border, r=kvark
* e3d7353a Fix overlapping border radii handling.

I filed https://github.com/servo/webrender/issues/2294 for this


second regression is due to:

*   45dc6a3a Auto merge of #2244 - glennw:dual-source-blending, r=kvark
|\
| * 5f6b3868 Add dual-source blending path for subpixel text when supported.
* 97479a41 Auto merge of #2242 - glennw:gen-seg8, r=kvark
* 9423cf20 Address review comments
* 6ef9d025 Adding edge flags to unit tests
* 479e48f5 Fix borders with pre-built segments not checking clip mask kind.
* fdac2304 Extend segment building to handle clip in/out, multiple clip regions.

I filed https://github.com/servo/webrender/issues/2293 for this

Comment 4

[Darkspirit]

This got almost fixed with a latest webrender update (https://github.com/servo/webrender/pull/2324 = bug 1430829). Thank you!
(Technically everything mentioned in the bug title is fixed. Do you want a spin-off or track it here?)

Remaining issues:
1) flickering line at the bottom when scrolling (like before: "good" from comment 2)
2) The diagram is visible in the tab bar when scrolling down, but it's distorted/not round there.

Comment 5

[Darkspirit]

Attachment: 2018-01-21_03-28-41.mp4

Nightly 59 x64 20180120220330 de_DE @ Debian Testing (KDE, Radeon RX480)
left side: non-WR
right side: WR

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Let's make a spinoff for the remaining issues. Otherwise the github issues pointing to this bug will get confusing too.

Comment 7

[Darkspirit]

> fixed with the latest webrender update (https://github.com/servo/webrender/pull/2324 = bug 1430829)

Comment 8

[Darkspirit]

> Technically everything mentioned in the bug title is fixed.