1424659 - signatures shouldn't have sequential spaces in them

Status: RESOLVED FIXED

(Socorro :: Signature, task, P1)

Description

[Darkspirit]

Affected crash signature: 
[@ gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat ] 

The problem:
"gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat"
from
https://crash-stats.mozilla.com/topcrashers/?product=Firefox&_facets_size=200&_range_type=build&days=14&process_type=gpu&platform=Linux&version=59.0a1
does not point to bug 1406230.

------

bug 1406230 links to 
https://crash-stats.mozilla.com/signature/?signature=gfxPlatform%3A%3AInit%20%7C%20mozilla%3A%3Awidget%3A%3AWindowSurfaceX11%3A%3AGetVisualFormat
> Signature report for gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat
-> has no results

but Socorro links to
https://crash-stats.mozilla.com/signature/?date=%3C2017-12-10T23%3A38%3A50%2B00%3A00&date=%3E%3D2017-11-26T23%3A38%3A50%2B00%3A00&product=Firefox&version=59.0a1&signature=gfxPlatform%3A%3AInit%20%20%7C%20mozilla%3A%3Awidget%3A%3AWindowSurfaceX11%3A%3AGetVisualFormat
> Signature report for gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat
-> has results

The difference:
Init%20%7C%20mozilla
Init%20%20%7C%20mozilla

Both "Signature report for gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat" are identical, but only the latter link which has two spaces (%20) between "Init" and "|" has results, although the crash signature doesn't have two spaces.

I don't know where to report this.

Comment 1

[Darkspirit]

Ah!

https://crash-stats.mozilla.com/report/index/eaaebf75-646b-4fcb-8685-dae170171205

> Firefox 59.0a1 Crash Report [@ gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat ]
and
> Signature 	gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat More Reports Search
do not include two spaces in the crash signature. I coppied this (wrong displayed) signature when creating bug 1406230.

The signature has two spaces between in the html source code ("Init  |") and link ("Init%20%20%7C"), but in the displayed end result.

I think Socorro should return something like "Init  |".

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Seems like the issue here should be that signatures shouldn't have multiple sequential spaces in it. We should have a rule that makes sure there's only one space. If we fix signature generation in the processor, then we don't have to handle this situation elsewhere.

Making this a P1 to look into it.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--making this a P1 for real.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bumping this bug to the signature component.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do this week, too.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4292: fixes bug 1424659 - nix consecutive spaces in signatures

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/fde54c594874f575c4fd1c8995cb92dcf208a22c
fixes bug 1424659 - nix consecutive spaces in signatures

Prior to this, it was possible (though rare) to have two spaces in a row
in signatures. That's tough because the webui shows that as a single
space and if you search for the single-space version, you won't get any
results.

This fixes that by establishing that signatures can't have more than 1
consecutive whitespace character. Further, this makes sure that all
non-space whitespace characters are converted to space and this
happens all before we truncate the signature.

I also changed SigTrunc to SigTruncate because "trunc" is an unnecessary
abbreviation.

https://github.com/mozilla-services/socorro/commit/87eb5aa4d85e355739b1db13df729e2675ceba99
Merge pull request #4292 from willkg/1424659-spaces

fixes bug 1424659 - nix consecutive spaces in signatures