1424706 - Deleting characters from awesomebar will not delete already existing site suggestions

Status: RESOLVED DUPLICATE of bug 1418103

(Firefox for iOS :: Home screen, defect, P2)

Description

[u549602]

Device: iPad 2 (10.3.3)
Build: Beta 10.4 (8245)

STR: 
1. Have some sites bookmarked and in History
2. Type in some characters in awesomebar to trigger suggestions
3. Delete typed in characters

Expected results: 
Suggestions should be deleted when awesomebar is clear

Actual result: 
Suggestions still displayed

For further details please check : 
https://www.youtube.com/watch?v=JTxX8QvcVGk&feature=youtu.be

Comment 1

[:garvan]

Dev note: we need to ensure we don't regress bug 1278470.

Comment 2

[:garvan]

Attachment: Pull request

The behaviour now matches Safari, deleting updates the list of results, but doesn't autocomplete the domain.

Farhan, please feel free to review at a later date when you are available.

Comment 3

[:garvan]

Comment on attachment 8945156 [details] [review]
Pull request

My quick fix could regress third party keyboards, which were tricky to get working in the first place. For instance I relied on `shouldChangeCharactersIn` which may not work with them. 
I'll step aside on this because it will need more than drive-by patching, and experimentation with non-standard KB.

Note the considerations here for future work: https://github.com/mozilla-mobile/firefox-ios/pull/3597