1424864 - Fix some issues raised when starting to enable no-undef on mobile/android.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Banner (:standard8)]

I've started looking at getting no-undef enabled for mobile/android.

I found a couple of instances of false positives, but also a couple of instances where error handling is using the wrong error type.

I have a patch for these that I'll upload in a moment.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1424864. Fix some minor issues raised by ESLint when enabling no-undef on mobile/android.

Review commit: https://reviewboard.mozilla.org/r/207094/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207094/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8936373 [details]
Bug 1424864. Fix some minor issues raised by ESLint when enabling no-undef on mobile/android.

Moving reviews to Nevin – I primarily work on the Activity Stream component of Firefox for Android.

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8936373 [details]
Bug 1424864. Fix some minor issues raised by ESLint when enabling no-undef on mobile/android.

https://reviewboard.mozilla.org/r/207094/#review214428

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dac40e5e9cff
Fix some minor issues raised by ESLint when enabling no-undef on mobile/android. r=nechen

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/dac40e5e9cff