1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Mark Banner (:standard8)]

Although there's currently various issues with no-undef across the mobile/android directory (see dependencies of bug 1424996), I think we should enable no-undef across as much as possible to avoid new issues creeping in.

Once bug 1424864 has landed, fixing some simple issues, the patch I'm about to attach will pass ESLint. The other dependencies of bug 1424996 can then fix the remaining issues and remove the restrictions.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible.

Review commit: https://reviewboard.mozilla.org/r/207362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207362/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8936620 [details]
Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207362/diff/1-2/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8936620 [details]
Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible.

Moving reviews to Nevin – I primarily work on the Activity Stream component of Firefox for Android.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8936620 [details]
Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207362/diff/2-3/

Comment 5

[Mark Banner (:standard8)]

Note: the updates here have been to remove exclusions for various bugs as they have been getting fixed :-)

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8936620 [details]
Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible.

https://reviewboard.mozilla.org/r/207362/#review215102

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d18fcc606dc7
Enable ESLint rule no-undef for as much of mobile/android as possible. r=nechen

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d18fcc606dc7