Closed Bug 1425052 Opened 2 years ago Closed 2 years ago

Enable ESLint rule no-undef for as much of mobile/android as possible

Categories

(Firefox for Android :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Although there's currently various issues with no-undef across the mobile/android directory (see dependencies of bug 1424996), I think we should enable no-undef across as much as possible to avoid new issues creeping in.

Once bug 1424864 has landed, fixing some simple issues, the patch I'm about to attach will pass ESLint. The other dependencies of bug 1424996 can then fix the remaining issues and remove the restrictions.
Depends on: 1424864
Comment on attachment 8936620 [details]
Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible.

Moving reviews to Nevin – I primarily work on the Activity Stream component of Firefox for Android.
Attachment #8936620 - Flags: review?(michael.l.comella) → review?(cnevinchen)
Note: the updates here have been to remove exclusions for various bugs as they have been getting fixed :-)
Comment on attachment 8936620 [details]
Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible.

https://reviewboard.mozilla.org/r/207362/#review215102

Thanks!
Attachment #8936620 - Flags: review?(cnevinchen) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d18fcc606dc7
Enable ESLint rule no-undef for as much of mobile/android as possible. r=nechen
https://hg.mozilla.org/mozilla-central/rev/d18fcc606dc7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.