1424909 - Progress meter for in-progress installs don't display properly

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Sören Hentzschel]

Attachment: screenshot

Something broke in the add-on manager a few days ago. Please see the attached screenshot, I saw this multiple times in the last few days while installing / updating add-ons.

Comment 1

[Andrew Swan [:aswan]]

I'm inclined to fix this by simply ripping installs out of the listing here.

Comment 2

[Valentina Claudia Ona]

Hi Soren,
Can you please tell which versions are affected to set the flags?

Comment 3

[Sören Hentzschel]

(In reply to Valentina Claudia Ona from comment #2)
> Hi Soren,
> Can you please tell which versions are affected to set the flags?

It's a regression in Firefox 59 Nightly.

(In reply to Andrew Swan [:aswan] from comment #1)
> I'm inclined to fix this by simply ripping installs out of the listing here.

I'm not sure if I understand this correctly but add-on updates are also affected.

I am also not sure about the priority (P5). My internet connection is often very slow and I get almost every day add-on updates so for me it's a highly visible visual regression in a core component of Firefox.

Comment 4

[Sören Hentzschel]

12:05.73 INFO: Last good revision: cd942db65cf93dad9688937034ef7f8fb91e5379
12:05.73 INFO: First bad revision: 2297e770f16c7411ff64dce3349a9406a59a9129
12:05.73 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cd942db65cf93dad9688937034ef7f8fb91e5379&tochange=2297e770f16c7411ff64dce3349a9406a59a9129

Regressed by bug 1263313.

Comment 5

[Andrew Overholt [:overholt]]

(In reply to Andrew Swan [:aswan] from comment #1)
> I'm inclined to fix this by simply ripping installs out of the listing here.

Given you marked this P5, should we stop tracking it as a regression in 59?

Comment 6

[Andrew Swan [:aswan]]

(In reply to Andrew Overholt [:overholt] from comment #5)
> Given you marked this P5, should we stop tracking it as a regression in 59?

I'm not sure exactly what the implications are of tracking as a regression, but this isn't a blocker for 59 if that's the issue.
Also, just looking at the screenshot, I am skeptical of the bug identified in comment 4, it looks much more likely to be related to bug 1422100.

Comment 7

[Sören Hentzschel]

(In reply to Andrew Swan [:aswan] from comment #6)
> (In reply to Andrew Overholt [:overholt] from comment #5)
> Also, just looking at the screenshot, I am skeptical of the bug identified
> in comment 4, it looks much more likely to be related to bug 1422100.

mozregression identified bug 1263313 as regressor. Bug 1422100 can't be the regressor because the patch from bug 1422100 landed four days before bug 1263313, so it's not in the regression range.

Comment 10

[Sören Hentzschel]

Firefox 59 will reach the Beta channel very soon and it's a visible regression in the add-on manager of Firefox. It affects not only new add-on install but also all add-on updates. I see the bug almost every day. I am surprised there is no activity at all since one month…

Comment 11

[Andy McKay]

I think we should address this, one way or another, sooner rather than later.

Comment 12

[Andrew Swan [:aswan]]

Attachment: Bug 1424909 Remove stray bracket in extensions.xml

Review commit: https://reviewboard.mozilla.org/r/214762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214762/

Comment 13

[Tomislav Jovanovic :zombie]

Comment on attachment 8944599 [details]
Bug 1424909 Remove stray bracket in extensions.xml

https://reviewboard.mozilla.org/r/214762/#review220414

o_O

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8774529a88f4
Remove stray bracket in extensions.xml r=zombie

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8774529a88f4

Comment 16

[Andrew Swan [:aswan]]

Comment on attachment 8944599 [details]
Bug 1424909 Remove stray bracket in extensions.xml

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1263313

[User impact if declined]:
visual glitch in about:addons

[Is this code covered by automated tests?]:
no

[Has the fix been verified in Nightly?]:
yes, manually

[Needs manual test from QE? If yes, steps to reproduce]: 
I don't think further manual verification is necessary

[List of other uplifts needed for the feature/fix]:
none

[Is the change risky?]:
no

[Why is the change risky/not risky?]:
The change is quite simple and from manual inspection, it just fixes an obvious typo.

[String changes made/needed]:
none

Comment 17

[Liz Henry (:lizzard)]

Comment on attachment 8944599 [details]
Bug 1424909 Remove stray bracket in extensions.xml

Typo fix, let's uplift for the beta 4 build. Happy to see this fixed in 59!

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/89da65446d75

Comment 19

[Itiel]

Looking good on latest Nightly.