Closed Bug 1422100 Opened 3 years ago Closed 3 years ago

Refactor in-content UI font sizes

Categories

(Toolkit :: Themes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(2 files)

See bug 1419867 comment 10 and below. These stylesheets try to set a font size on every element directly with rem values and it's a big mess.
Comment on attachment 8933427 [details]
Bug 1422100 - Refactor in-content UI font sizes.

https://reviewboard.mozilla.org/r/204354/#review209910

Looks really good, thank you for cleaning this up. However, I noticed that the listitems in the 'Use Bookmark...' subdialog has a different font-size than Nightly. I'll upload a screenshot, with that fixed I'll grant r+.
Attachment #8933427 - Flags: review?(jaws) → review-
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Comment on attachment 8933427 [details]
> Bug 1422100 - Refactor in-content UI font sizes.
> 
> https://reviewboard.mozilla.org/r/204354/#review209910
> 
> Looks really good, thank you for cleaning this up. However, I noticed that
> the listitems in the 'Use Bookmark...' subdialog has a different font-size
> than Nightly. I'll upload a screenshot, with that fixed I'll grant r+.

It's more consistent now. For instance, the "Applications" table or the "Choose your preferred language for displaying pages" list don't get a smaller font size in Nightly.
Attachment #8933427 - Flags: review- → review?(jaws)
Comment on attachment 8933427 [details]
Bug 1422100 - Refactor in-content UI font sizes.

https://reviewboard.mozilla.org/r/204354/#review210288

Good point. Thanks again.
Attachment #8933427 - Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b59a30cbdbff
Refactor in-content UI font sizes. r=jaws
https://hg.mozilla.org/mozilla-central/rev/b59a30cbdbff
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1423441
Depends on: 1425724
Depends on: 1425729
Depends on: 1425822
Depends on: 1426368
See Also: → 1428957
You need to log in before you can comment on or make changes to this bug.