Closed
Bug 1422100
Opened 7 years ago
Closed 7 years ago
Refactor in-content UI font sizes
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | unaffected |
| firefox59 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(2 files)
Screenshot of 'Use Bookmark...' subdialog
See bug 1419867 comment 10 and below. These stylesheets try to set a font size on every element directly with rem values and it's a big mess.
|
Assignee | |
Updated•7 years ago
|
status-firefox58:
--- → unaffected
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8933427 [details]
Bug 1422100 - Refactor in-content UI font sizes.
https://reviewboard.mozilla.org/r/204354/#review209910
Looks really good, thank you for cleaning this up. However, I noticed that the listitems in the 'Use Bookmark...' subdialog has a different font-size than Nightly. I'll upload a screenshot, with that fixed I'll grant r+.
Attachment #8933427 -
Flags: review?(jaws) → review-
|
|
||
Comment 3•7 years ago
|
||
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Comment on attachment 8933427 [details]
> Bug 1422100 - Refactor in-content UI font sizes.
>
> https://reviewboard.mozilla.org/r/204354/#review209910
>
> Looks really good, thank you for cleaning this up. However, I noticed that
> the listitems in the 'Use Bookmark...' subdialog has a different font-size
> than Nightly. I'll upload a screenshot, with that fixed I'll grant r+.
It's more consistent now. For instance, the "Applications" table or the "Choose your preferred language for displaying pages" list don't get a smaller font size in Nightly.
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8933427 -
Flags: review- → review?(jaws)
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8933427 [details]
Bug 1422100 - Refactor in-content UI font sizes.
https://reviewboard.mozilla.org/r/204354/#review210288
Good point. Thanks again.
Attachment #8933427 -
Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b59a30cbdbff
Refactor in-content UI font sizes. r=jaws
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•