All users were logged out of Bugzilla on October 13th, 2018

Need access to OnShowContextMenu()

NEW
Assigned to

Status

--
enhancement
17 years ago
7 years ago

People

(Reporter: galfandary, Assigned: blizzard)

Tracking

Trunk
Sun
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
EmbedWindow needs to implement nsIContextMenuListener
and forward a corresponding signal to the embedded widget.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Created attachment 143136 [details] [diff] [review]
proposed implementation

This patch implements a "dom_context_menu" signal on GtkMozEmbed.
Comment on attachment 143136 [details] [diff] [review]
proposed implementation

Asking for r/sr
Attachment #143136 - Flags: superreview?(bryner)
Attachment #143136 - Flags: review?(blizzard)
Comment on attachment 143136 [details] [diff] [review]
proposed implementation

Looks fine given how the other event listeners are implemented.

However, I'm a bit worried about event cancellation being implemented by
returning something other than NS_OK from the DOM event listener.  That doesn't
really accomplish much afaik.  It seems like you'd want a boolean which would
then cause event->PreventDefault() to be called if it is set by the signal
callback.  I'm ok with cleaning this up later though.
Attachment #143136 - Flags: superreview?(bryner) → superreview+
(Assignee)

Comment 4

15 years ago
Comment on attachment 143136 [details] [diff] [review]
proposed implementation

I hate to be a jerk but I would rather get the event handling right.  We have
enough problems with event handling as it is.
Attachment #143136 - Flags: review?(blizzard) → review-
*** Bug 206713 has been marked as a duplicate of this bug. ***
QA Contact: pavlov → gtk-widget
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.