Closed
Bug 142510
Opened 23 years ago
Closed 7 years ago
Need access to OnShowContextMenu()
Categories
(Core Graveyard :: Embedding: GTK Widget, enhancement)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: galfandary, Assigned: blizzard)
References
Details
Attachments
(1 file)
12.25 KB,
patch
|
blizzard
:
review-
bryner
:
superreview+
|
Details | Diff | Splinter Review |
EmbedWindow needs to implement nsIContextMenuListener
and forward a corresponding signal to the embedded widget.
![]() |
||
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•21 years ago
|
||
This patch implements a "dom_context_menu" signal on GtkMozEmbed.
Comment 2•21 years ago
|
||
Comment on attachment 143136 [details] [diff] [review]
proposed implementation
Asking for r/sr
Attachment #143136 -
Flags: superreview?(bryner)
Attachment #143136 -
Flags: review?(blizzard)
Comment 3•21 years ago
|
||
Comment on attachment 143136 [details] [diff] [review]
proposed implementation
Looks fine given how the other event listeners are implemented.
However, I'm a bit worried about event cancellation being implemented by
returning something other than NS_OK from the DOM event listener. That doesn't
really accomplish much afaik. It seems like you'd want a boolean which would
then cause event->PreventDefault() to be called if it is set by the signal
callback. I'm ok with cleaning this up later though.
Attachment #143136 -
Flags: superreview?(bryner) → superreview+
Assignee | ||
Comment 4•21 years ago
|
||
Comment on attachment 143136 [details] [diff] [review]
proposed implementation
I hate to be a jerk but I would rather get the event handling right. We have
enough problems with event handling as it is.
Attachment #143136 -
Flags: review?(blizzard) → review-
Comment 5•20 years ago
|
||
*** Bug 206713 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
QA Contact: pavlov → gtk-widget
Updated•13 years ago
|
Product: Core → Core Graveyard
Comment 6•7 years ago
|
||
Embedding: GTK Widget isn't a thing, closing.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•