urlbar/location bar/address bar text/URL not updated when its popup/panel is open and pushState or replaceState is called

NEW
Unassigned

Status

()

defect
P5
normal
2 years ago
2 years ago

People

(Reporter: yuessiah, Unassigned)

Tracking

57 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

Reporter

Description

2 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171129231020

Steps to reproduce:

While viewing "https://github.com/mozilla/firefox57-sprint", I clicked the ".gitignore" hyperlink, the address bar normally showed me "https://github.com/mozilla/firefox57-sprint/blob/master/.gitignore" .


Actual results:

but if I modify something in address bar like "https://github.com/mozilla/firefox57-sprint" -> "mozilla/firefox57", after clicking the ".gitignore", the address bar would not be updated.


Expected results:

The address bar should be updated when clicking hyperlink.
click ".gitignore", "https://github.com/mozilla/firefox57-sprint" will become "https://github.com/mozilla/firefox57-sprint/blob/master/.gitignore"
Reporter

Comment 1

2 years ago
(In reply to yuessiah from comment #0)
> User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101
> Firefox/57.0
> Build ID: 20171129231020
> 
> Steps to reproduce:
> 
> While viewing "https://github.com/mozilla/firefox57-sprint", I clicked the
> ".gitignore" hyperlink, the address bar normally showed me
> "https://github.com/mozilla/firefox57-sprint/blob/master/.gitignore" .
> 
> 
> Actual results:
> 
> but if I modify something in address bar like
> "https://github.com/mozilla/firefox57-sprint" -> "mozilla/firefox57", after
> clicking the ".gitignore", the address bar would not be updated.
> 
> 
> Expected results:
> 
> The address bar should be updated when clicking hyperlink.
> click ".gitignore", "https://github.com/mozilla/firefox57-sprint" will
> become "https://github.com/mozilla/firefox57-sprint/blob/master/.gitignore"
Component: Untriaged → Address Bar
Reporter

Comment 2

2 years ago
sorry for everyone,
I tweak something in Expected results
---

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171129231020

Steps to reproduce:

While viewing "https://github.com/mozilla/firefox57-sprint", I clicked the ".gitignore" hyperlink, the address bar normally showed me "https://github.com/mozilla/firefox57-sprint/blob/master/.gitignore" .


Actual results:

but if I modify something in address bar like "https://github.com/mozilla/firefox57-sprint" -> "mozilla/firefox57", after clicking the ".gitignore", the address bar would not be updated.


Expected results:

The address bar should be updated when clicking hyperlink.
click ".gitignore", "mozilla/firefox57" will become "https://github.com/mozilla/firefox57-sprint/blob/master/.gitignore"
Clearer STR:

1. Open https://github.com/mozilla/firefox57-sprint
2. Type something ("foo") in the urlbar *and do not close the urlbar popup*
3. With the urlbar popup still open, click a link in the file listing on the GitHub page (e..g, .gitignore)

The text in the urlbar remains whatever you typed in step 2.  If you close the popup instead before clicking the link in step 3, the urlbar is updated.

This only happens on GitHub, not other sites I briefly tried.  I bet it's related to history.pushState().  I think that's what GitHub's using when you click on a link in a file listing.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Yeah, looks like a problem with pushState/replaceState.  I made a simple test case.  Not sure whether this bug belongs in the front end or back end, but I'll leave it here for now pending more investigation.  The fact that the problem happens when the popup is open but not when it's closed probably points to the front end.
Priority: -- → P5
Summary: The address bar not showing well after accessing another page → urlbar/location bar/address bar text/URL not updated when its popup/panel is open and pushState or replaceState is called
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.