1425290 - Standardize default target folder also for "Bookmark This Link" and Bookmark this frame

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Follow up of bug #1120110 to standardize default output folder for adding bookmarks by various methods, even by using "Bookmark This Link" item in hyperlink menu

Comment 1

[Marco Bonardo [:mak]]

Forwarding to bbell, should be also unify the Bookmark This Link destination, or should we leave it alone?

Comment 3

[Marco Bonardo [:mak]]

All the bookmarking operations are currently going to unfiled, apart from Bookmark This Link and Bookmarks This Frame that are going to the menu.

I think we should unify them to unfiled bookmarks, then we can look into bug 1412263 to provide an option to change the default globally. Whether that option should be exposed an a Preference or hidden in about:config is still TBD.

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Since this bug is not a high priority, a regression, or a security issue, it's not necessary to track its status.

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Looks like Bryan Bell [:bbell] Bugzilla account is disabled, so I'm dropping needinfo? request.

@ Marco Bonardo [:mak] - As triage owner, do you know who could take this over? Thank you very much in advance!

Comment 6

[Marco Bonardo [:mak]]

We don't have a UX referent atm, looking around for a future rresourced team to take care of these things.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r?mak

Depends on D94500

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1425290 - also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r?mak

Depends on D94879

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6b38d403cc3
use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
https://hg.mozilla.org/integration/autoland/rev/cf70da964b70
also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_bookmarkProperties_addKeywordForThisSearch.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d2c0ca2f17bd606bc01e65c6b62663da16a82488
Log link: https://treeherder.mozilla.org/logviewer?job_id=320868524&repo=autoland&lineNumber=4573

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca3a56aafb99
use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
https://hg.mozilla.org/integration/autoland/rev/6354c3742a1a
also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ca3a56aafb99
https://hg.mozilla.org/mozilla-central/rev/6354c3742a1a

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 84.0a1 (2020-11-06), so I'm marking this bug as VERIFIED.
Thank you very much! \o/