1425461 - Crash in mozilla::gfx::RecordedSourceSurfaceCreation::Record<T>

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-6a8f9047-b7d1-48ab-b0f3-b128b0171111.
=============================================================

Seen while looking at nightly crash stats - looks like about 27 crashes/14 installs in the last week: http://bit.ly/2Ci92ju

Top 10 frames of crashing thread:

0 xul.dll mozilla::gfx::RecordedSourceSurfaceCreation::Record<mozilla::gfx::MemWriter> gfx/2d/RecordedEventImpl.h:2477
1 xul.dll mozilla::gfx::RecordedEventDerived<mozilla::gfx::RecordedSourceSurfaceCreation>::RecordToStream gfx/2d/RecordedEventImpl.h:38
2 xul.dll mozilla::gfx::StoreSourceSurfaceRecording gfx/2d/DrawTargetWrapAndRecord.cpp:54
3 xul.dll mozilla::gfx::EnsureSurfaceStoredRecording gfx/2d/DrawTargetWrapAndRecord.cpp:69
4 xul.dll mozilla::gfx::DrawTargetRecording::EnsurePatternDependenciesStored gfx/2d/DrawTargetRecording.cpp:643
5 xul.dll mozilla::gfx::DrawTargetRecording::FillRect gfx/2d/DrawTargetRecording.cpp:268
6 xul.dll gfxSurfaceDrawable::DrawInternal gfx/thebes/gfxDrawable.cpp:104
7 xul.dll gfxSurfaceDrawable::Draw gfx/thebes/gfxDrawable.cpp:74
8 xul.dll gfxUtils::DrawPixelSnapped gfx/thebes/gfxUtils.cpp:584
9 xul.dll mozilla::image::imgFrame::Draw image/imgFrame.cpp:586

=============================================================

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This might be due to a realloc fail at https://searchfox.org/mozilla-central/rev/110706c3c09d457dc70293b213d7bccb4f6f5643/gfx/2d/RecordedEvent.h#199 - it doesn't look like we check for that failure mode.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Last one was in buildid 20180312134431 but it's low volume enough that it might still be happening. We should probably guard against the realloc fail at some point.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Doesn't block release.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.