Closed Bug 1425974 Opened 2 years ago Closed 2 years ago

browser_aboutSearchReset.js is going to permafail when the Gecko version number is bumped to 60

Categories

(Firefox :: Search, enhancement, P1, major)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: florian)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing tests when the Gecko version number is bumped to 60.

Should we extend the SEARCH_RESET_RESULT probe expiration again, Florian?
Flags: needinfo?(florian)
Priority: -- → P1
Whiteboard: [fxsearch]
The early/first merge will be Jan. 11th. 
Tracking so we can make sure to check back in early January. 
Does extending a probe that was scheduled to expire need a data review?
Attached patch bump to 65Splinter Review
Given that we just shipped this UI in Firefox 57.0.1 (in bug 1419941) and haven't analyzed the results yet, now is the worst possible time to drop this probe. Let's bump it by a couple more releases. I think this is straightforward enough that it could land without data review, flagging Panos to check if he agrees or wants to figure out who to loop in (as bsmedberg handled the review of the previous bumps but is no longer around).
Attachment #8938374 - Flags: review?(past)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8938374 [details] [diff] [review]
bump to 65

Review of attachment 8938374 [details] [diff] [review]:
-----------------------------------------------------------------

Let's err on the side of caution and ask Rebecca if a normal data review process is required for a probe expiration extension.
Attachment #8938374 - Flags: review?(rweiss)
Attachment #8938374 - Flags: review?(past)
Attachment #8938374 - Flags: review+
liuche, could you take the data review here? Thanks!
Flags: needinfo?(florian) → needinfo?(liuche)
Comment on attachment 8938374 [details] [diff] [review]
bump to 65

Try confirms that this fixes the issues with this test.
Attachment #8938374 - Flags: feedback+
Comment on attachment 8938374 [details] [diff] [review]
bump to 65

Review of attachment 8938374 [details] [diff] [review]:
-----------------------------------------------------------------

Yes! Approving this extension of the probe.
Attachment #8938374 - Flags: review?(rweiss) → review+
Flags: needinfo?(liuche)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a64b8a0a98a3
Keep the SEARCH_RESET_RESULT Telemetry probe until Firefox 65. r=past, data-r=liuche
https://hg.mozilla.org/mozilla-central/rev/a64b8a0a98a3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.