1426140 - JS module tests related to error handling currently fail

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jon Coppeard (:jonco)]

The following web platform tests currently fail:

html/semantics/scripting-1/the-script-element/module/load-error-events-inline.html
html/semantics/scripting-1/the-script-element/module/errorhandling.html

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1426140-1-refactor-error-handling

Factor out error handling from ScriptLoader::OnStreamComplete() into a new method.

I moved the test for NS_BINDING_RETARGETED to before the call to HandleError.  I don't think it's possible for rv to be NS_ERROR_TRACKING_URI while aChannelError is NS_BINDING_RETARGETED so this shouldn't matter.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bug1426140-2-refactor-onstreamcomplete

While I was there I broke OnStreamComplete up a bit to make it easier to follow.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug1426140-3-fix-error-handling

Now the fix.  Call ProcessFetchedModuleSource and HandleLoadError for inline module scripts and move the call to SetModuleFetchFinishedAndResumeWaitingRequests to HandleError for the error case so that it gets called for fetch errors that happen before ProcessFetchedModuleSource gets called.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8937746 [details] [diff] [review]
bug1426140-2-refactor-onstreamcomplete

Review of attachment 8937746 [details] [diff] [review]:
-----------------------------------------------------------------

maybe some of those new methods can be const.

::: dom/script/ScriptLoader.cpp
@@ +2872,5 @@
>  }
>  
>  void
> +ScriptLoader::ReportErrorToConsole(ScriptLoadRequest *aRequest, nsresult aResult)
> +{

MOZ_ASSERT(aRequest);

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b06fe374260
Factor out error handling from ScriptLoader::OnStreamComplete r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/54ba9609db75
Factor out SRI handling from ScriptLoader::OnStreamComplete r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8f97458d0cc
Handle errors for inline module scripts and ensure we update the module map after fetch errors r=baku

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2b06fe374260
https://hg.mozilla.org/mozilla-central/rev/54ba9609db75
https://hg.mozilla.org/mozilla-central/rev/a8f97458d0cc