1426198 - Skip the linker major version check for lld builds

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(Away)]

Comparing the linker version against the cl version doesn't make sense in lld builds.

I suppose we _could_ try to check against the clang version, but I don't see much value in it.

Comment 1

[(Away)]

Attachment: linkerversion

(Note the $LINKER comes from bug 1425906 being earlier in my patch queue)

This case statement feels a little bit awkward, but I wanted to include any form like lld-link, lld-link.exe, and also $LINKER is a full path at this point.

Let me know if there's a nicer way to do this.

Comment 2

[(not currently active) Ted Mielczarek]

I'd be inclined to move this all to toolchain.configure and then presumably you'd have better info and could skip the check if the compiler is msvc.

Comment 3

[(Away)]

I am more than happy for someone who isn't me to do that.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/424f72637e6f
Skip the linker version check in lld builds. r=glandium

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/424f72637e6f