Closed Bug 1426330 Opened 2 years ago Closed 2 years ago

[mozinfo] Add support for Python 3

Categories

(Testing :: Mozbase, enhancement)

Version 2
enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: vedantc98, Assigned: vedantc98, Mentored)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

We need to add Python 3 support without dropping support for legacy python.
Hi William
I've made an initial patch, should I trigger a try build?
I've already run it through the linter locally.
Comment on attachment 8938825 [details]
Bug 1426330 - Add python 3 support for mozinfo.

https://reviewboard.mozilla.org/r/209332/#review215134

::: testing/mozbase/mozinfo/setup.py:12
(Diff revision 1)
>  from setuptools import setup
>  
>  PACKAGE_VERSION = '0.10'
>  
>  # dependencies
>  deps = ['mozfile >= 0.12']

You'll need to add six to the list of dependencies.
Attachment #8938825 - Flags: review?(wlachance) → review-
Comment on attachment 8938825 [details]
Bug 1426330 - Add python 3 support for mozinfo.

https://reviewboard.mozilla.org/r/209332/#review215134

Looks good minus one nit. I'll trigger a try run for this, in the future feel free to do so yourself. I think for most cases doing all unit tests on linux64 opt should be sufficient.
Hopefully that should do it, unless the try build has any issues.
Thanks!
Comment on attachment 8938825 [details]
Bug 1426330 - Add python 3 support for mozinfo.

https://reviewboard.mozilla.org/r/209332/#review215530

lgtm, the failing try job was an intermittent.
Attachment #8938825 - Flags: review?(wlachance) → review+
Pushed by wlachance@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f157614c397d
Add python 3 support for mozinfo. r=wlach
https://hg.mozilla.org/mozilla-central/rev/f157614c397d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.