1426330 - [mozinfo] Add support for Python 3

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Vedant Chakravadhanula(:vedantc98)]

We need to add Python 3 support without dropping support for legacy python.

Comment 1

[Vedant Chakravadhanula(:vedantc98)]

Attachment: Bug 1426330 - Add python 3 support for mozinfo.

Review commit: https://reviewboard.mozilla.org/r/209332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209332/

Comment 2

[Vedant Chakravadhanula(:vedantc98)]

Hi William
I've made an initial patch, should I trigger a try build?
I've already run it through the linter locally.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8938825 [details]
Bug 1426330 - Add python 3 support for mozinfo.

https://reviewboard.mozilla.org/r/209332/#review215134

::: testing/mozbase/mozinfo/setup.py:12
(Diff revision 1)
>  from setuptools import setup
>  
>  PACKAGE_VERSION = '0.10'
>  
>  # dependencies
>  deps = ['mozfile >= 0.12']

You'll need to add six to the list of dependencies.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8938825 [details]
Bug 1426330 - Add python 3 support for mozinfo.

https://reviewboard.mozilla.org/r/209332/#review215134

Looks good minus one nit. I'll trigger a try run for this, in the future feel free to do so yourself. I think for most cases doing all unit tests on linux64 opt should be sufficient.

Comment 5

[Vedant Chakravadhanula(:vedantc98)]

Comment on attachment 8938825 [details]
Bug 1426330 - Add python 3 support for mozinfo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209332/diff/1-2/

Comment 6

[Vedant Chakravadhanula(:vedantc98)]

Hopefully that should do it, unless the try build has any issues.
Thanks!

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8938825 [details]
Bug 1426330 - Add python 3 support for mozinfo.

https://reviewboard.mozilla.org/r/209332/#review215530

lgtm, the failing try job was an intermittent.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f157614c397d
Add python 3 support for mozinfo. r=wlach

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f157614c397d