1428461 - mozharness copy of mozinfo is out of date

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Geoff Brown [:gbrown]]

testing/mozharness/mozinfo was initially copied from testing/mozbase/mozinfo/mozinfo. mozbase's mozinfo has evolved, but most changes have not been migrated to mozharness.

One known consequence is bug 1428137.

Comment 1

[Geoff Brown [:gbrown]]

For the most part, it looks easy to copy mozbase/mozinfo -> mozharness/mozinfo and all's well. There is a complication from the recent change in bug 1426330: It added a dependency on the "six" module, which isn't normally available in the mozharness environment. I'm not 100% sure, but I have a feeling it will be difficult to import six in mozinfo in mozharness.

:vedantc98/:wlach -- Would it be possible to not use "six" in mozinfo?

Comment 2

[William Lachance (:wlach)]

Should be pretty trivial, we only use one part of six in mozinfo (stringtypes):

https://searchfox.org/mozilla-central/rev/0a895028f74cffa67561150d10700abca8a931d8/testing/mozbase/mozinfo/mozinfo/mozinfo.py#19

You could replace the calls to six with a copypaste from that file:

https://github.com/benjaminp/six/blob/master/six.py#L49

Would be happy to review a patch if you want to make one :)

Comment 3

[Geoff Brown [:gbrown]]

Attachment: decouple mozinfo from six

Great! Let's do that.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8940375 [details] [diff] [review]
decouple mozinfo from six

Review of attachment 8940375 [details] [diff] [review]:
-----------------------------------------------------------------

wfm!

Comment 5

[Geoff Brown [:gbrown]]

Attachment: update testing/mozharness/mozinfo from testing/mozbase/mozinfo/mozinfo

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b991034e209484b81a34addef40946181629712

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8940585 [details] [diff] [review]
update testing/mozharness/mozinfo from testing/mozbase/mozinfo/mozinfo

Review of attachment 8940585 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for updating this

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b4b7cb6959e
Decouple mozinfo from the six module; r=wlach
https://hg.mozilla.org/integration/mozilla-inbound/rev/66c7d59eb914
Update mozharness' mozinfo from mozbase; r=jmaher

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1b4b7cb6959e
https://hg.mozilla.org/mozilla-central/rev/66c7d59eb914