1426596 - Update ANGLE in 60

Status: RESOLVED DUPLICATE of bug 1440849

(Core :: Graphics: CanvasWebGL, enhancement, P1)

Description

[Kelsey Gilbert [:jgilbert]]

Let's see if we can't pull an update real quick.

Here are the outstanding non-upstreamed patches:
https://public.etherpad-mozilla.org/p/angle-upstream-59

Fortunately, they're all pretty simple and should be easy to re-apply, though one of them had a file name change.

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d18242f46a6058fd1e732f52b38f9423afc10986

I've made a branch with top-of-tree ANGLE and pushed a try.

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

/builds/worker/workspace/build/src/obj-firefox/dist/include/angle/ShaderVars.h:291:31: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] [log…] 

Oh..... Why can't we just spare those 3rd-party code......

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70774d51e7aa8dc1ea3308405330a69980518fdc&selectedJob=153797731

Looks like there are a bunch of WebGL oranges, most of them are texture-related, maybe we still need some changes to apply it on.

Comment 4

[Michael Leu[:Lenzak](UTC+8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5262d6f3553ccc8a1b65aa1adcdc0bebd6cccc0&selectedJob=154057984

After uplift patch in Bug 1347866, there is only one fail which is dom/canvas/test/webgl-conf/generated/test_conformance__textures__misc__texture-npot-video.html, I'm now finding which changeset we made in local is responsible for it.

Comment 5

[Michael Leu[:Lenzak](UTC+8)]

Hi Jeff,

I'm quite sure I've applied our ANGLE local changesets which are not upstreamed yet,
but dom/canvas/test/webgl-conf/generated/test_conformance__textures__misc__texture-npot-video.html still fails,
and it doesn't look like a fail happens in previous ANGLE upgrade,
I think this fail has something to do with newer ANGLE's change.

Interestingly, we have an intermittent fail described in bug 1396649 which have exactly same failing pattern, I'm not sure about whether it is relevant, though.

Besides, we only have testfails in texture-npot-video.html, but not in texture-npot.html, so maybe the problem is related to video element.

I'm now investigating it, any suggestion about it?

Comment 6

[Kelsey Gilbert [:jgilbert]]

(In reply to Michael Leu[:Lenzak](UTC+8) from comment #4)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=c5262d6f3553ccc8a1b65aa1adcdc0bebd6cccc0&selectedJob=1
> 54057984
> 
> After uplift patch in Bug 1347866, there is only one fail which is
> dom/canvas/test/webgl-conf/generated/
> test_conformance__textures__misc__texture-npot-video.html, I'm now finding
> which changeset we made in local is responsible for it.

That patch should not be necessary anymore. We should debug what's going wrong there. I upstreamed those changes already, so they should be in top-of-tree.

Comment 7

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - Update Angle to TreeTop for testing

Review commit: https://reviewboard.mozilla.org/r/211244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211244/

Comment 8

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - Fix moz.build

Review commit: https://reviewboard.mozilla.org/r/211246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211246/

Comment 9

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - Fix WebGLShaderValidator.cpp

Review commit: https://reviewboard.mozilla.org/r/211248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211248/

Comment 10

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - Rebase half float support in textures(Bug 1325741)

Review commit: https://reviewboard.mozilla.org/r/211606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211606/

Comment 11

[Michael Leu[:Lenzak](UTC+8)]

I am quite sure that the patch in Bug 1325741 is not fully upstreamed yet.

We will fail those R11G11B10 float texture tests if we do not rebase the patch.

Comment 12

[Kelsey Gilbert [:jgilbert]]

(In reply to Michael Leu[:Lenzak](UTC+8) from comment #11)
> I am quite sure that the patch in Bug 1325741 is not fully upstreamed yet.
> 
> We will fail those R11G11B10 float texture tests if we do not rebase the
> patch.

Identify and fix the bug without using the patch that's supposed to have been upstreamed. It's likely something wasn't quite upstreamed properly, but we shouldn't take that whole old patch to try to fix it. Fix it in a new patch.

Comment 13

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - Rebase(Bug 1421199)

Review commit: https://reviewboard.mozilla.org/r/212854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212854/

Comment 14

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - Rebase(Bug 1415754)

Review commit: https://reviewboard.mozilla.org/r/212856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212856/

Comment 15

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - s/ANGLE_stream_producer_d3d_texture_nv12/ANGLE_stream_producer_d3d_texture/g

Review commit: https://reviewboard.mozilla.org/r/212858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212858/

Comment 16

[Michael Leu[:Lenzak](UTC+8)]

It seems that ANGLE changes some of their extension name so we cannot correctly identify those which related to NV12 stream producers, we can fix it by updating gecko side's symbol declaration.

Comment 17

[Michael Leu[:Lenzak](UTC+8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a797315667cca72841c3db8c6f214115e6e0a99

Now the texture-npot-video passed, I'm fixing the moz.build part on mac to make our cross-compiler happier.

Comment 18

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1426596 - Turn of missing braces warning to make compiler happier

Review commit: https://reviewboard.mozilla.org/r/212882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212882/

Comment 19

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8940971 [details]
Bug 1426596 - Update Angle to TreeTop for testing

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211244/diff/1-2/

Comment 20

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8940972 [details]
Bug 1426596 - Fix moz.build

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211246/diff/1-2/

Comment 21

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8940973 [details]
Bug 1426596 - Fix WebGLShaderValidator.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211248/diff/1-2/

Comment 22

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8941308 [details]
Bug 1426596 - Rebase half float support in textures(Bug 1325741)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211606/diff/1-2/

Comment 23

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8942592 [details]
Bug 1426596 - Rebase(Bug 1421199)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212854/diff/1-2/

Comment 24

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8942593 [details]
Bug 1426596 - Rebase(Bug 1415754)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212856/diff/1-2/

Comment 25

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8942594 [details]
Bug 1426596 - s/ANGLE_stream_producer_d3d_texture_nv12/ANGLE_stream_producer_d3d_texture/g

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212858/diff/1-2/

Comment 26

[Michael Leu[:Lenzak](UTC+8)]

There are 2 issues left.

One is an assertion inside array-length-side-effect test in debug build, however, this test has no problem in release build, so I suspect it is an ANGLE bug, I'll build ANGLE standalone and write a simple cpp program to test ANGLE's debug build to verify it.

And the other is a fail in tex-3d-rgb11_11_10, it is very similar to the fail when we were updating ANGLE in bug 1371190, but this time is tex-3d instead of tex-2d, although this can be fixed by rebasing our old patch, I think this is caused by different problem and worthwhile to investigate it.

Comment 27

[Michael Leu[:Lenzak](UTC+8)]

OK, I can confirm the crash inside array-length-side-effect is an ANGLE bug, I can reproduce it by writing a simple cpp program with building ANGLE translator standalone, I have reported it to Google.
https://bugs.chromium.org/p/angleproject/issues/detail?id=2307

Comment 28

[Michael Leu[:Lenzak](UTC+8)]

https://chromium-review.googlesource.com/c/angle/angle/+/874691

ANGLE has fixed the shader compiler problem.

I'm sorry I cannot do it further.

Good bye.