Closed Bug 1347866 Opened 3 years ago Closed 3 years ago

Update ANGLE to chromium/2950

Categories

(Core :: Canvas: WebGL, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: cleu, Assigned: cleu)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files, 3 obsolete files)

This version of ANGLE introduced several bugfix and support for Async/Multithread D3D shader compilation which improves its shader compile speed.
Assignee: nobody → cleu
Blocks: 1212878
Attached patch Update ANGLE to build 2950 (obsolete) — Splinter Review
Attachment #8848992 - Flags: review?(jgilbert)
Attachment #8848993 - Flags: review?(jgilbert)
Attachment #8848992 - Attachment is obsolete: true
Attachment #8848992 - Flags: review?(jgilbert)
Attachment #8848993 - Attachment is obsolete: true
Attachment #8848993 - Flags: review?(jgilbert)
It seems that removing the for-loop unrolling flag cause mochitest-gl fail under Linux.

The flag is dropped in the changeset.
https://github.com/google/angle/commit/1b896c62934be40cf8a37dc28fabc15590c89a5d

I think we should revert it and apply this flag for only Linux.
Attachment #8854696 - Attachment is obsolete: true
Attachment #8854696 - Flags: review?(jgilbert)
Try looks good now after remove the changeset removing SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e474a501dded2c4834e0bc06d4f8b00b2bef2468&selectedJob=88789618
Comment on attachment 8854693 [details]
Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling"

https://reviewboard.mozilla.org/r/126654/#review130796

Bug 1324972 was fixed upstream.
Attachment #8854693 - Flags: review?(jgilbert) → review-
Comment on attachment 8854694 [details]
Bug 1347866 - Part3: ANGLE patch uplift for bug1325733;

https://reviewboard.mozilla.org/r/126656/#review130798
Attachment #8854694 - Flags: review?(jgilbert) → review+
Comment on attachment 8854695 [details]
Bug 1347866 - Part4: ANGLE patch uplift for bug1325741;

https://reviewboard.mozilla.org/r/126658/#review130800
Attachment #8854695 - Flags: review?(jgilbert) → review+
Comment on attachment 8854692 [details]
Bug 1347866 - Part1: Update ANGLE to chromium/2950;

https://reviewboard.mozilla.org/r/126652/#review130806

Update ANGLE in its own commit, and then add a commit that reverts anything. We need them to be separate so it's easy to track how much we differ from ANGLE upstream.
Attachment #8854692 - Flags: review?(jgilbert) → review-
Comment on attachment 8854692 [details]
Bug 1347866 - Part1: Update ANGLE to chromium/2950;

https://reviewboard.mozilla.org/r/126652/#review131190
Attachment #8854692 - Flags: review?(jgilbert) → review+
Comment on attachment 8854693 [details]
Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling"

https://reviewboard.mozilla.org/r/126654/#review131194

Please file a bug about trying to remove this requirement. We should figure out if Chrome's fixing this another way.
Attachment #8854693 - Flags: review?(jgilbert) → review+
See Also: → 1355321
Depends on: 1355321
See Also: 1355321
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fd9927e85ae
Part1: Update ANGLE to chromium/2950; r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/7aeaeae6fc91
Part2: Revert "translator: remove code related to for-loop unrolling" r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/d9165d5725b7
Part3: ANGLE patch uplift for bug1325733; r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/3caa5ec38d18
Part4: ANGLE patch uplift for bug1325741; r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d9165d5725b7
https://hg.mozilla.org/mozilla-central/rev/3caa5ec38d18
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Duplicate of this bug: 863316
Blocks: 1382851
You need to log in before you can comment on or make changes to this bug.