Closed
Bug 1347866
Opened 6 years ago
Closed 6 years ago
Update ANGLE to chromium/2950
Categories
(Core :: Graphics: CanvasWebGL, enhancement)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: cleu, Assigned: cleu)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files, 3 obsolete files)
This version of ANGLE introduced several bugfix and support for Async/Multithread D3D shader compilation which improves its shader compile speed.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8848992 -
Flags: review?(jgilbert)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8848993 -
Flags: review?(jgilbert)
|
||
Comment 3•6 years ago
|
||
I need to upstream these bugs into ANGLE first: https://bugzilla.mozilla.org/show_bug.cgi?id=1324972 https://bugzilla.mozilla.org/show_bug.cgi?id=1325733 https://bugzilla.mozilla.org/show_bug.cgi?id=1325741
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8848992 -
Attachment is obsolete: true
Attachment #8848992 -
Flags: review?(jgilbert)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8848993 -
Attachment is obsolete: true
Attachment #8848993 -
Flags: review?(jgilbert)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9e65c329fb9f647ba29c9d455e069bd2dfe53ec Submit a mochitest-gl try task.
|
|
Assignee | |
Comment 10•6 years ago
|
||
It seems that removing the for-loop unrolling flag cause mochitest-gl fail under Linux. The flag is dropped in the changeset. https://github.com/google/angle/commit/1b896c62934be40cf8a37dc28fabc15590c89a5d I think we should revert it and apply this flag for only Linux.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8854696 -
Attachment is obsolete: true
Attachment #8854696 -
Flags: review?(jgilbert)
|
|
Assignee | |
Comment 15•6 years ago
|
||
Try looks good now after remove the changeset removing SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX https://treeherder.mozilla.org/#/jobs?repo=try&revision=e474a501dded2c4834e0bc06d4f8b00b2bef2468&selectedJob=88789618
|
|
||
Comment 16•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8854693 [details] Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling" https://reviewboard.mozilla.org/r/126654/#review130796 Bug 1324972 was fixed upstream.
Attachment #8854693 -
Flags: review?(jgilbert) → review-
|
|
||
Comment 17•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8854694 [details] Bug 1347866 - Part3: ANGLE patch uplift for bug1325733; https://reviewboard.mozilla.org/r/126656/#review130798
Attachment #8854694 -
Flags: review?(jgilbert) → review+
|
|
||
Comment 18•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8854695 [details] Bug 1347866 - Part4: ANGLE patch uplift for bug1325741; https://reviewboard.mozilla.org/r/126658/#review130800
Attachment #8854695 -
Flags: review?(jgilbert) → review+
|
|
||
Comment 19•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8854692 [details] Bug 1347866 - Part1: Update ANGLE to chromium/2950; https://reviewboard.mozilla.org/r/126652/#review130806 Update ANGLE in its own commit, and then add a commit that reverts anything. We need them to be separate so it's easy to track how much we differ from ANGLE upstream.
Attachment #8854692 -
Flags: review?(jgilbert) → review-
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•6 years ago
|
Blocks: CVE-2017-5459
|
|
||
Updated•6 years ago
|
No longer blocks: CVE-2017-5459
|
|
||
Updated•6 years ago
|
Blocks: CVE-2017-5031
|
|
||
Comment 24•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8854692 [details] Bug 1347866 - Part1: Update ANGLE to chromium/2950; https://reviewboard.mozilla.org/r/126652/#review131190
Attachment #8854692 -
Flags: review?(jgilbert) → review+
|
|
||
Comment 25•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8854693 [details] Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling" https://reviewboard.mozilla.org/r/126654/#review131194 Please file a bug about trying to remove this requirement. We should figure out if Chrome's fixing this another way.
Attachment #8854693 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Comment 26•6 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fd9927e85ae Part1: Update ANGLE to chromium/2950; r=jgilbert https://hg.mozilla.org/integration/autoland/rev/7aeaeae6fc91 Part2: Revert "translator: remove code related to for-loop unrolling" r=jgilbert https://hg.mozilla.org/integration/autoland/rev/d9165d5725b7 Part3: ANGLE patch uplift for bug1325733; r=jgilbert https://hg.mozilla.org/integration/autoland/rev/3caa5ec38d18 Part4: ANGLE patch uplift for bug1325741; r=jgilbert
Keywords: checkin-needed
|
||
Comment 27•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d9165d5725b7 https://hg.mozilla.org/mozilla-central/rev/3caa5ec38d18
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•