Stop using the gtk+3 tooltool package

RESOLVED FIXED in Firefox 59

Status

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla59
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(5 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
I should mention that I did a diff between builds with and without this patch queue, and the differences are trivial:
- SourceStamp (obviously).
- Linked library order in .dynamic sections.
- buildconfig.html changes from the mozconfig changes.
Attachment #8938567 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8938568 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8938569 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8938570 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8938571 - Flags: review?(core-build-config-reviews) → review?(gps)

Comment 7

a year ago
mozreview-review
Comment on attachment 8938567 [details]
Bug 1426785 - Install gtk+3 in the Centos images used for desktop builds.

https://reviewboard.mozilla.org/r/209208/#review215058
Attachment #8938567 - Flags: review?(gps) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8938568 [details]
Bug 1426785 - Allow more `mach artifact toolchain` calls to not use a tooltool manifest.

https://reviewboard.mozilla.org/r/209210/#review215060
Attachment #8938568 - Flags: review?(gps) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8938569 [details]
Bug 1426785 - Use gtk+3 from /usr/local on automation.

https://reviewboard.mozilla.org/r/209212/#review215062
Attachment #8938569 - Flags: review?(gps) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8938570 [details]
Bug 1426785 - Remove uses of the gtk+3 tooltool package.

https://reviewboard.mozilla.org/r/209214/#review215064

Niiiiice.
Attachment #8938570 - Flags: review?(gps) → review+

Comment 11

a year ago
mozreview-review
Comment on attachment 8938571 [details]
Bug 1426785 - Remove mozconfig.gtk.

https://reviewboard.mozilla.org/r/209216/#review215066

Great series!

Since this is only touching Mozilla's abilities to use gtk2 in official CI, I'm fine landing this before we officially drop gtk2 support in general.

FWIW, my previous attempts at merging the desktop-build Docker image were somewhat foiled by pkg-config and gtk. I'm glad to see this situation greatly simplified. And I'm sure there's more awesomeness to come.
Attachment #8938571 - Flags: review?(gps) → review+

Comment 12

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/2a52bf9e0898
Install gtk+3 in the Centos images used for desktop builds. r=gps
https://hg.mozilla.org/integration/autoland/rev/386cd0532519
Allow more `mach artifact toolchain` calls to not use a tooltool manifest. r=gps
https://hg.mozilla.org/integration/autoland/rev/851ce8944b41
Use gtk+3 from /usr/local on automation. r=gps
https://hg.mozilla.org/integration/autoland/rev/61453b6473f1
Remove uses of the gtk+3 tooltool package. r=gps
https://hg.mozilla.org/integration/autoland/rev/08b5850633de
Remove mozconfig.gtk. r=gps

Comment 14

a year ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9452138c4e83
Keep build files in sync (Port bug 1426785: Remove mozconfig.gtk). rs=bustage-fix

Comment 16

a year ago
Backout by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2a682edf04ac
Backed out changeset 9452138c4e83 since ported bug 1426785 was backed out. rs=bustage-fix
(Assignee)

Comment 17

a year ago
Need some more cleanup around the removed tooltool manifests. I'm going to land directly with those fixups, without re-review because:
- This is (mostly) only about removing tooltool_manifest_src entries for the browser/config/tooltool-manifests/linux*/releng.manifest that is removed.
- The remainder is a change to _run_tooltool in testing/mozharness/scripts/repackage.py that a) mimicks the code in testing/mozharness/mozharness/mozilla/building/buildbase.py b) don't throw an error if there's nothing to download from tooltool because repacks don't actually necessarily need anything from tooltool (case in point: linux builds now don't ; and in fact they didn't really require that manifest in the first place, cargo curl ftw)
Flags: needinfo?(mh+mozilla)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 23

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/83a7d1921b05
Install gtk+3 in the Centos images used for desktop builds. r=gps
https://hg.mozilla.org/integration/autoland/rev/101f3a29dc4f
Allow more `mach artifact toolchain` calls to not use a tooltool manifest. r=gps
https://hg.mozilla.org/integration/autoland/rev/e9eacb78877a
Use gtk+3 from /usr/local on automation. r=gps
https://hg.mozilla.org/integration/autoland/rev/83fabeaf6582
Remove uses of the gtk+3 tooltool package. r=gps
https://hg.mozilla.org/integration/autoland/rev/68d6c3cb89eb
Remove mozconfig.gtk. r=gps

Comment 25

a year ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/13c3ef7d9883
Keep build files in sync (Port bug 1426785: Remove mozconfig.gtk). rs=bustage-fix

Comment 26

a year ago
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/2cf483e70c05
Re-add config to use tooltool gtk for Thunderbird buildbots; r=me

Comment 27

a year ago
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/be410fe9478c
Drop tooltool manifests for linux taskcluster builds; r=me
(Assignee)

Updated

a year ago
Depends on: 1427232

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.