1427232 - Gtk+3 cleanups in centos build environment

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1427232 - Remove .la files when building gtk3.

In bug 1426785, Gtk+3 build was moved to docker image creation time, and
at the same time, the removal of .la files was stripped, because it
seemed too broad to do that in /usr/local/lib*, and because I didn't
really remember why it was there in the first place.

I now do remember, and that's because libtool likes to add useless
dependencies on libraries just because direct dependencies transitively
depend on them. For example, this adds a dependency on libffi to
libpangocairo, which doesn't use it directly.

I also happens that /usr/local/lib* is empty at the moment we build
gtk3, so we can just do the cleanup there.

On its own, this change is useless, but:
- it restores the libraries in their state pre-bug 1426785,
- it helps reduce some differences when building on Debian (for bug
1399679), easing the comparison of those builds.

Review commit: https://reviewboard.mozilla.org/r/209430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209430/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1427232 - Install expat-devel before building gtk3.

fontconfig uses expat by default to read its xml configuration, but when
expat is not there at build time, it falls back to libxml2. We ended up
in this situation, while on Debian, fontconfig is built against expat.

This makes no practical difference, since we're not actually using
fontconfig, but for some reason, the difference in dependencies has an
impact on how ld chooses to arrange the .plt and .got.plt sections,
meaning that even though the code and data is originally identical, in
the .o files, the resulting linked machine code is largely different
because of all the applied relocations changing the offsets of e.g. call
instructions for function calls through the .plt. This results in large
differences in .plt, .init, .text, .data.rel.ro, as well as symbols list
when building on Debian.

This thus is meant to help make the differences more tractable.

Review commit: https://reviewboard.mozilla.org/r/209432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209432/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8938982 [details]
Bug 1427232 - Remove .la files when building gtk3.

https://reviewboard.mozilla.org/r/209430/#review215208

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8938983 [details]
Bug 1427232 - Install expat-devel before building gtk3.

https://reviewboard.mozilla.org/r/209432/#review215210

If this is meant as temporary, an inline comment to that effect would be useful.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8938983 [details]
Bug 1427232 - Install expat-devel before building gtk3.

https://reviewboard.mozilla.org/r/209432/#review215210

It's only temporary in that it will go away at the same time as the centos based desktop-build image, but in the desktop-build image itself, it's not meant to be temporary. It's actually better this way, fontconfig intends expat to be what it uses to read its config.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30386b610adb
Remove .la files when building gtk3. r=gps
https://hg.mozilla.org/integration/autoland/rev/62b9b376360f
Install expat-devel before building gtk3. r=gps

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/30386b610adb
https://hg.mozilla.org/mozilla-central/rev/62b9b376360f