1426866 - Certificate Manager broken by Bug 1425688

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[vtol]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce:

TB 59.0a1 (2017-12-22) (64-bit) on Win 10 W10 x64 (b16299)

Tools > Options > Advanced > Manage Certificates > Your Certificates > Import


Actual results:

pressing "Import" nothing happens


Expected results:

pressing "Import" should open a file explorer window in order to point and pick the certificate(s) desired to import

Comment 1

[Richard Marti (:Paenglab)]

I see this too on today Nightly.
Errors in console when opening the Certmanager:
SyntaxError: redeclaration of const Services  certManager.js:1:1
	<anonymous> chrome://pippki/content/certManager.js:1:1
ReferenceError: LoadCerts is not defined[Learn More]  certManager.xul:1:1
	onload chrome://pippki/content/certManager.xul:1:1

And clicking on Import... I get:
ReferenceError: restoreCerts is not defined[Learn More]  certManager.xul:1:1
	oncommand chrome://pippki/content/certManager.xul:1:1

Backout of bug 1425688 fixes this for me.

Comment 3

[Jorg K (CEST = GMT+2)]

Right, still working in Daily of 2017-12-21.

Mark, what do we need to do to get this working again? Looking briefly at this, I don't see any TB specific code. certManager.xul and JS files are in M-C.

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #1)
> I see this too on today Nightly.
You mean Nightly FF or Daily TB?

Comment 5

[Richard Marti (:Paenglab)]

Nightly is FX. So yes, in FX. Thai's why I moved this bug to m-c.

Comment 7

[Masatoshi Kimura [:emk]]

Moreover, no certificates are listed in the Certificate Manager at all. Bug 1425688 completely broke the Certificate Manager. It should be backed out ASAP.

Comment 8

[Jorg K (CEST = GMT+2)]

Fixed by backout of bug 1425688.