Open Bug 1426981 Opened 6 years ago Updated 1 year ago

Intermittent browser/extensions/formautofill/test/browser/browser_update_doorhanger.js | Uncaught exception - TypeError: can't access dead object

Categories

(Toolkit :: Form Autofill, enhancement, P3)

enhancement

Tracking

()

REOPENED

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled][cc-autofill-reserve])

Attachments

(2 files)

Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=153242661&repo=mozilla-central

https://queue.taskcluster.net/v1/task/LZdzYl-CQkKYiqyjId7Z3Q/runs/0/artifacts/public/logs/live_backing.log

[task 2017-12-23T23:39:29.106Z] 23:39:29     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_update_doorhanger.js | Uncaught exception - TypeError: can't access dead object
8961
[task 2017-12-23T23:39:29.107Z] 23:39:29     INFO - Leaving test bound test_submit_untouched_fields
8962
[task 2017-12-23T23:39:29.111Z] 23:39:29     INFO - Entering test bound test_submit_reduced_fields
8963
[task 2017-12-23T23:39:29.111Z] 23:39:29     INFO - expecting record retrievals: addresses
Depends on: 1377636
There are 49 failures in the last 7 days. 
Failures per platform:
Windows7-32  -> 19 failures. Mostly on pgo (only 1 on opt)
Windows10-64 -> 11 failures. Pgo&opt
Linux64      -> 8 failures
Linux32      -> 6 failures
Osx-10-10    -> 4 failures

Recent failure log and snippet with the failure:
https://treeherder.mozilla.org/logviewer.html#?job_id=171844861&repo=mozilla-inbound&lineNumber=5047

13:51:06     INFO -  1108 INFO Console message: [JavaScript Warning: "Error in parsing value for ‘height’.  Declaration dropped." {file: "chrome://browser/content/browser.xul" line: 0}]
13:51:06     INFO -  Buffered messages finished
13:51:06    ERROR -  1109 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_update_doorhanger.js | Uncaught exception - TypeError: can't access dead object
13:51:06     INFO -  1110 INFO Leaving test bound test_create_new_address
13:51:06     INFO -  1111 INFO Entering test bound test_create_new_address_merge
13:51:06     INFO -  1112 INFO expecting record retrievals: addresses

:jmhaer, I see that Luke Chang (triage owner) appears as "inactive". Can you please NI someone else that can take a look?
Thanks
Flags: needinfo?(jmaher)
Whiteboard: [stockwell needswork]
:mattn, this is another form autofill bug that is high frequency as of this week, can you help find the right person to work on this?
Flags: needinfo?(jmaher) → needinfo?(MattN+bmo)
In the last 7 days we have 73 failures.
They occur on Linux (debug, opt), Linux x64 (debug, opt, pgo, asan), linux64-ccov (opt), linux64-nightly (opt), OS X 10.10 (debug, opt), Windows 7 (opt, pgo), windows10-64 (opt, pgo), windows10-64-ccov (debug).
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=171769640&repo=mozilla-inbound&lineNumber=5074
Nothing jumps out at me that would cause a dead object.

Added some logging at https://treeherder.mozilla.org/#/jobs?repo=try&revision=3214185e3c9b0b80684343142738aee2be6efd29
Flags: needinfo?(MattN+bmo)
Priority: P5 → P1
See Also: → 1426595
I also can't reproduce it locally so far
thanks for looking into this :mattn
So my current suspicion is that the issue is from `form.querySelector("input[type=submit]").click();` closing the dialog and causing the content task frame script to access a dead object in the dialog that just closed.

Testing that theory: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc5b1746c057e09166f66bb4d3b7cf8a36f8f244
:mattn, there are 139 failures in the last 7 days for this fail. 
Do you have any updates?
My last try push didn't show the failure with many retriggers even though I only added logging…
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
There are 126 failures in the last 7 days.
Most of them are on Linux (82 failures) and 53 of them are on "opt".
38 failures are on Windows (7&10) and 9 on OS.X

:mattn, there is something we can do to fix it or should we disable this test at least on Linux?
Flags: needinfo?(MattN+bmo)
That showed a bug in another test. https://treeherder.mozilla.org/#/jobs?repo=try&revision=4532b6ebb5832cb2055780470277a1917598fcb0 should fix that and will hopefully fix other tests that use the helper I'm fixing.
Try looks great!
Flags: needinfo?(MattN+bmo)
Comment on attachment 8970039 [details]
Bug 1426981 - Fix formautofill expectPopupOpen helper to wait until there are autocomplete items.

https://reviewboard.mozilla.org/r/238790/#review244480
Attachment #8970039 - Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/68a1436f3e09
Fix formautofill expectPopupOpen helper to wait until there are autocomplete items. r=MattN
For future reference, the dead object was because the DOWN and ENTER key was being sent before the popup was actually opened so the ENTER key which was simply supposed to select the autofill entry in the popup was instead submitting the form thus causing a navigation away so that the content task would refer to the old document.
I made a change to some CSS in bug 1443396 and it was backed out due to high failures for this bug.  I can't think of any reason why my CSS change would affect this test, but if someone else knows, I'd be grateful for their help.  Thanks.
I can't see how it would be related so it was likely an incorrect backout. Either way you can wait to land after this is merged.
https://hg.mozilla.org/mozilla-central/rev/68a1436f3e09
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
This is still happening.

[task 2018-04-23T19:53:27.898Z] 19:53:27     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_update_doorhanger.js | Still 2 addresses in storage - 
[task 2018-04-23T19:53:27.899Z] 19:53:27     INFO - Leaving test bound test_create_new_address_merge
[task 2018-04-23T19:53:27.899Z] 19:53:27     INFO - Entering test bound test_submit_untouched_fields
[task 2018-04-23T19:53:27.900Z] 19:53:27     INFO - expecting record retrievals: addresses
[task 2018-04-23T19:53:27.900Z] 19:53:27     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_update_doorhanger.js | 2 addresses in storage - 
[task 2018-04-23T19:53:27.902Z] 19:53:27     INFO - expecting the target input being focused and identified
[task 2018-04-23T19:53:27.902Z] 19:53:27     INFO - !previouslyFocused
[task 2018-04-23T19:53:27.903Z] 19:53:27     INFO - FieldsIdentified
[task 2018-04-23T19:53:27.903Z] 19:53:27     INFO - Buffered messages logged at 19:53:25
[task 2018-04-23T19:53:27.903Z] 19:53:27     INFO - openPopupOn: before VK_DOWN
[task 2018-04-23T19:53:27.904Z] 19:53:27     INFO - expectPopupOpen
[task 2018-04-23T19:53:27.905Z] 19:53:27     INFO - getDisplayedPopupItems
[task 2018-04-23T19:53:27.905Z] 19:53:27     INFO - before down
[task 2018-04-23T19:53:27.906Z] 19:53:27     INFO - after down, before return
[task 2018-04-23T19:53:27.906Z] 19:53:27     INFO - after return
[task 2018-04-23T19:53:27.907Z] 19:53:27     INFO - Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Index out of range." {file: "resource://formautofill/ProfileAutoCompleteResult.jsm" line: 83}]
[task 2018-04-23T19:53:27.908Z] 19:53:27     INFO - Buffered messages finished
[task 2018-04-23T19:53:27.909Z] 19:53:27     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_update_doorhanger.js | Uncaught exception - TypeError: can't access dead object
[task 2018-04-23T19:53:27.910Z] 19:53:27     INFO - Leaving test bound test_submit_untouched_fields
[task 2018-04-23T19:53:27.911Z] 19:53:27     INFO - Entering test bound test_submit_reduced_fields
[task 2018-04-23T19:53:27.911Z] 19:53:27     INFO - expecting record retrievals: addresses
[task 2018-04-23T19:53:27.913Z] 19:53:27     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_update_doorhanger.js | 2 addresses in storage - 
[task 2018-04-23T19:53:27.913Z] 19:53:27     INFO - expecting the target input being focused and identified
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Can you please have a look at this or should we disable it?
Flags: needinfo?(MattN+bmo)
Disabled test browser_update_doorhanger.js on all platforms(linux, os X, windows).
Attachment #8971278 - Flags: review?(jmaher)
Comment on attachment 8971278 [details] [diff] [review]
Disabled test browser_update_doorhanger.js on all platforms.

Review of attachment 8971278 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8971278 - Flags: review?(jmaher) → review+
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89f8eb048586
Disable test browser_update_doorhanger.js on all platforms. r=jmaher
Keywords: checkin-needed
Assignee: MattN+bmo → nobody
Flags: needinfo?(MattN+bmo)
Type: defect → enhancement
Keywords: leave-open
OS: Unspecified → All
Priority: P1 → P3
Hardware: Unspecified → All
Whiteboard: [stockwell disabled] → [stockwell disabled][cc-autofill-reserve]
Target Milestone: mozilla61 → ---
Version: unspecified → Trunk
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.